tests: ci: allow parallel npm installs by stephenplusplus · Pull Request #1596 · googleapis/google-cloud-node

stephenplusplus · 2016-09-15T02:15:27Z

No description provided.

coveralls · 2016-09-15T04:49:08Z

Coverage remained the same at 100.0% when pulling 6393317 on stephenplusplus:spp--ci-speed-up into 35573c3 on GoogleCloudPlatform:master.

stephenplusplus · 2016-09-15T12:08:49Z

@callmehiphop this has sped up our builds quite a bit!

Previously, each environment would require around ~15-17 minutes just to run npm installs, before running any tests. Now we've got it down to ~8-17 for the tests to complete.

Sign in to view

-  - 4
  - 0.12
+  - 4
+  - 6


coveralls · 2016-09-15T16:18:43Z

Coverage remained the same at 100.0% when pulling f4effa6 on stephenplusplus:spp--ci-speed-up into 35573c3 on GoogleCloudPlatform:master.

Sign in to view

+  - packages\resource\node_modules -> packages\resource\package.json
+  - packages\storage\node_modules -> packages\storage\package.json
+  - packages\translate\node_modules -> packages\translate\package.json
+  - packages\vision\node_modules -> packages\vision\package.json


coveralls · 2016-09-15T16:40:28Z

Coverage remained the same at 100.0% when pulling 0c9dd98 on stephenplusplus:spp--ci-speed-up into 35573c3 on GoogleCloudPlatform:master.

coveralls · 2016-09-15T19:28:32Z

Coverage remained the same at 100.0% when pulling 0aeafa6 on stephenplusplus:spp--ci-speed-up into 35573c3 on GoogleCloudPlatform:master.

coveralls · 2016-09-15T19:28:32Z

Coverage remained the same at 100.0% when pulling 0aeafa6 on stephenplusplus:spp--ci-speed-up into 35573c3 on GoogleCloudPlatform:master.

stephenplusplus · 2016-09-15T20:24:56Z

Even though it took 100 commits, this should be an improvement over what we have now. It might take more tweaking, but that's just another 100-commit PR away.

## Description This PR achieves the same objectives as https://togithub.com/googleapis/java-bigquery/pull/4010, but for Node as requested in [the planning sheet](https://docs.google.com/spreadsheets/d/1cHAw6cV8k_s40hw28C8STtlymu3MXEvTY6PaKgdgSGE/edit?resourcekey=0-hPyTawvew5ugN037XCfZXg&gid=0#gid=0). The idea is that for reading rows, the users should be able to access high precision values for timestamps if high precision values are being stored on the backend. ## Impact This PR follows a test driven development approach against the getRows method. Tests were written to evaluate what happens when getRows receives various input values for timestampOutputFormat and useInt64Timestamp. These tests revealed that not only are high precision values not being delivered to users for ISO8601_STRING return types, but also other bugs exist like calls hang on getRows calls that fail and conversion logic throughs errors for some calls that fetch rows. This PR fixes all the bugs and ensures the values with the right precision are delivered to users. This chart details the before code changes / after code changes results with impact highlighted in green: <img width="1575" height="383" alt="image" src="https://togithub.com/user-attachments/assets/75c1ff70-073c-477e-9363-8eff5be0aa5f" /> The highlighted green impact shows that conversion logic has been updated to avoid the 'cannot convert' errors and with this new logic changes are also applied to the BigQueryTimestamp class to maintain high precision on timestamp values returned to users. ## Testing New system tests to capture all useInt64Timestamp/timestampOutputFormat combinations for getRows calls.

…ls (#1596)" This reverts commit b3217a3. # Conflicts: # handwritten/bigquery/src/table.ts

* Revert "feat: Add high precision TIMESTAMP values for queries (#7147)" This reverts commit bea42b2. # Conflicts: # handwritten/bigquery/src/bigquery.ts # handwritten/bigquery/src/job.ts # handwritten/bigquery/test/bigquery.ts * Revert "feat: support high precision timestamp strings on getRows calls (#1596)" This reverts commit b3217a3. # Conflicts: # handwritten/bigquery/src/table.ts * skip a test * Remove the High Precision Query System tests * Source code changes for timestamp precision flag * Add tests back * Add test file back in * Modify tests to only run for high precision or not * listParams add * remove listParams * skip tests if picosecond support is not turned on * remove only * Don’t create separate code paths when not needed * extend the default options * Skip the before hook if picosecond support not on * Add documentation back in for methods * Remove the if block since release is done * Eliminate redundant feature flag check. * Add qs back in * Add commands to test for picoseconds in system t * Revert "Remove the if block since release is done" This reverts commit 757dfdc. * Eliminate environment variable for parsing check * Always use try block * Change type to GetRowsOptions * Remove exception * Some typescript simplifications * Eliminate default options branching * Change defaults for current requests * Don’t need extra import * Don’t gate with picosecond flag * Just add an extra test file * test(bigquery): parameterize system tests for picosecond support Wraps the BigQuery system tests in a parameterized function to run them both with and without the BIGQUERY_PICOSECOND_SUPPORT environment variable. Clients and resources are re-instantiated within a before hook to ensure the library picks up the environment changes for each run. The existing indentation is preserved to maintain a clean PR diff. Co-authored-by: danieljbruce <[email protected]> * test(bigquery): add high precision timestamp wrapper system test Creates a new system test file that programmatically re-runs the entire BigQuery system test suite with BIGQUERY_PICOSECOND_SUPPORT=true. This is achieved by clearing the Node.js require cache for the package and requiring the existing bigquery.ts test file within a new describe block. This approach leaves the original test file untouched, ensuring a clean PR diff and avoiding linting issues. Co-authored-by: danieljbruce <[email protected]> * linting change and copyright year * Correct package.json errors * This file is not working well with test runner * Run the timestamp output format tests as well * Add a wrapper --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: danieljbruce <[email protected]>

tests: ci: see if eachLimit stops AppVeyor errors

41e1d5b

stephenplusplus added the testing label Sep 15, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016

stephenplusplus added 5 commits September 14, 2016 22:19

try npm 2

2d49c28

try force

c55603a

try retries

f4e2c4b

up the parallel limit

c4312be

allow more time before restarting

6393317

stephenplusplus changed the title ~~tests: ci: see if eachLimit stops AppVeyor errors~~ tests: ci: allow parallel npm installs Sep 15, 2016

stephenplusplus assigned callmehiphop Sep 15, 2016

stephenplusplus commented Sep 15, 2016

View reviewed changes

Comment thread .travis.yml

- 4

- 0.12

- 4

- 6

This comment was marked as spam.

Sign in to view

stephenplusplus added 12 commits September 15, 2016 08:43

cache node_modules in travis

ac84890

cache node_modules in appveyor

1c0fa73

fix appveyor formatting

62b7d70

fix appveyor formatting

6b58b93

fix appveyor formatting

9ca6bb2

get packages from manifest.json

8487bdc

limit parallel installs to 5

ab9b4d9

limit install attempts

7b9d1eb

add each modules node_modules directory to cache appveyor

e6a55ed

add specific cache dirs to travis

5ee8233

lower parallel limit

c50de24

learn basic OS differences

069d952

stephenplusplus unassigned callmehiphop Sep 15, 2016

stephenplusplus added the don't merge label Sep 15, 2016

add retries back in

1756aa6

stephenplusplus force-pushed the spp--ci-speed-up branch from d60ff8e to 1756aa6 Compare September 15, 2016 14:51

remove prop

f4effa6

allow more time for expiration date tests

0c9dd98

add cache-min

0aeafa6

callmehiphop reviewed Sep 15, 2016

View reviewed changes

stephenplusplus removed the don't merge label Sep 15, 2016

stephenplusplus assigned callmehiphop Sep 15, 2016

callmehiphop merged commit af8ca8d into googleapis:master Sep 19, 2016

sofisl pushed a commit that referenced this pull request Feb 25, 2026

tests: ci: allow parallel npm installs (#1596)

f419f96

GautamSharda pushed a commit that referenced this pull request Mar 11, 2026

fix: pin @opentelemetry/semantic-conventions for Node 12 support (#1596)

3b92227

danieljbruce added a commit that referenced this pull request Mar 31, 2026

Revert "feat: support high precision timestamp strings on getRows cal…

f31ccc7

…ls (#1596)" This reverts commit b3217a3. # Conflicts: # handwritten/bigquery/src/table.ts

Conversation

stephenplusplus commented Sep 15, 2016

Uh oh!

coveralls commented Sep 15, 2016

Uh oh!

stephenplusplus commented Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Sep 15, 2016

Uh oh!

stephenplusplus commented Sep 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stephenplusplus commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading

coveralls commented Sep 15, 2016 •

edited

Loading