logging: allow for encoding options#1427
Closed
callmehiphop wants to merge 1 commit intogoogleapis:masterfrom
callmehiphop:log-encoding
Closed
logging: allow for encoding options#1427callmehiphop wants to merge 1 commit intogoogleapis:masterfrom callmehiphop:log-encoding
callmehiphop wants to merge 1 commit intogoogleapis:masterfrom
callmehiphop:log-encoding
Conversation
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
Contributor
|
I think the problem here was at one point during the PR, I renamed |
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
Mar 18, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we're getting some logging failures on Travis.
@stephenplusplus Not sure if I'm way off on this one, but essentially I've added support for "encoding" options when writing a log. LMKWYT and if it looks ok, I'll update the documentation and add some unit tests!