Docs: WritableStream -> WriteStream#1401
Merged
stephenplusplus merged 3 commits intogoogleapis:masterfrom Jul 1, 2016
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
I think we should favor |
Contributor
Author
|
No problem. Do you want to change ReadStream to ReadableStream as well then? |
This reverts commit da96c27.
Contributor
Author
|
I went ahead changing readstream to readable stream. Also added the missing return type for File.create(read/write)stream |
Contributor
|
Perfect! Thanks again :) |
sofisl
pushed a commit
that referenced
this pull request
Feb 3, 2026
* chore: update types from Discovery * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alvaro Viebrantz <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
* fix: remove disrespectful terms * updated signatures * updated policies and signatures * revert v4 conformance test data changes Co-authored-by: Frank Natividad <[email protected]>
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
🤖 I have created a release \*beep\* \*boop\* --- ### [5.9.1](https://www.github.com/googleapis/nodejs-spanner/compare/v5.9.0...v5.9.1) (2021-06-24) ### Bug Fixes * make request optional in all cases ([#1400](https://www.github.com/googleapis/nodejs-spanner/issues/1400)) ([0b78770](https://www.github.com/googleapis/nodejs-spanner/commit/0b78770bfef6f463abb0f336999f7dfd61b5b2fe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda
pushed a commit
that referenced
this pull request
Mar 5, 2026
* chore(main): release 10.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
thiyaguk09
pushed a commit
to thiyaguk09/google-cloud-node-fork
that referenced
this pull request
Mar 18, 2026
* fix: remove disrespectful terms * updated signatures * updated policies and signatures * revert v4 conformance test data changes Co-authored-by: Frank Natividad <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not pretty sure about this one though.
Because it writes
WriteStreamin another placeActually, in
fsit is calledfs.WriteStreambut the underlying class/interface isstream.Writable. I am not sure what it is referring to...