Skip to content

datastore: add query.run#1280

Merged
callmehiphop merged 4 commits intogoogleapis:masterfrom
stephenplusplus:spp--1266
May 5, 2016
Merged

datastore: add query.run#1280
callmehiphop merged 4 commits intogoogleapis:masterfrom
stephenplusplus:spp--1266

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus commented May 3, 2016

Fixes #1266

To Dos

  • Docs
  • Tests
    • System
    • Unit

Previously, a query has only been created through {module:datastore#createQuery}. But since adding run on the Query object, we need a reference to the parent object. The only thing that made this a bit tricky was running a query inside of a transaction. That's why this PR has to introduce {module:transaction#createQuery}.

@stephenplusplus stephenplusplus added api: datastore Issues related to the Datastore API. don't merge labels May 3, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 3, 2016
@stephenplusplus
Copy link
Copy Markdown
Contributor Author

@callmehiphop ptal!

Comment thread lib/datastore/query.js
* //-
* var query = datastore.createQuery('Person')
* .hasAncestor(datastore.key(['Person', 1234]))
* .hasAncestor(datastore.key(['Person', 'Dave']))

This comment was marked as spam.

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

Fixed the docs issue + realized query.run didn't take an options, which is required for setting the consistency.

@coveralls
Copy link
Copy Markdown

coveralls commented May 5, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling acdb279 on stephenplusplus:spp--1266 into 243b52d on GoogleCloudPlatform:master.

@callmehiphop callmehiphop merged commit f4e431f into googleapis:master May 5, 2016
@callmehiphop
Copy link
Copy Markdown
Contributor

LGTM!

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
sofisl pushed a commit that referenced this pull request Feb 3, 2026
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/is](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/is) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`0.0.22` -> `0.0.23`](https://renovatebot.com/diffs/npm/@types%2fis/0.0.22/0.0.23) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fis/0.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fis/0.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fis/0.0.22/0.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fis/0.0.22/0.0.23?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/nodejs-bigquery).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
sofisl pushed a commit that referenced this pull request Feb 24, 2026
* feat: Build query/document mapping in bundles.

* fix system test failure.

* fix lint error.

* Remove ugly swap.

* Mutiple queries mapping and never go back in time.

* Address comments and fix system-tests

* Fix system-tests.
sofisl pushed a commit that referenced this pull request Feb 26, 2026
GautamSharda pushed a commit that referenced this pull request Mar 5, 2026
* chore(main): release 10.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants