tests: run tests against node v6#1277
Merged
callmehiphop merged 2 commits intogoogleapis:masterfrom May 2, 2016
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Do we still care about v5? It looks like only v4 and v6 are LTS. |
Contributor
Author
|
Later, 5! |
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7114bcc2-d850-48f7-b57d-30d464b3c964/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 344883170 Source-Link: googleapis/googleapis@370e9f9
GautamSharda
pushed a commit
that referenced
this pull request
Mar 23, 2026
* Fix parsing for qualifiers with colon characters * Update ci.yaml * fix: Support names with no qualifier * revert: remove workflow_dispatch * fix: Update test to check null qualifiers instead of undefined * fix: Respect column names without qualifiers * fix: Clean up for lint errors * fix: Remove remaining trailing space * revert: "fix: Update test to check null qualifiers instead of undefined" This reverts commit 1275dd56cd8aea668703e1f83daecfd14d5199f6. * fix: Allow undefined qualifiers in ParsedColumn * test: Add test for qualifier names with colons --------- Co-authored-by: danieljbruce <[email protected]>
GautamSharda
pushed a commit
that referenced
this pull request
Mar 25, 2026
* Fix parsing for qualifiers with colon characters * Update ci.yaml * fix: Support names with no qualifier * revert: remove workflow_dispatch * fix: Update test to check null qualifiers instead of undefined * fix: Respect column names without qualifiers * fix: Clean up for lint errors * fix: Remove remaining trailing space * revert: "fix: Update test to check null qualifiers instead of undefined" This reverts commit 1275dd56cd8aea668703e1f83daecfd14d5199f6. * fix: Allow undefined qualifiers in ParsedColumn * test: Add test for qualifier names with colons --------- Co-authored-by: danieljbruce <[email protected]>
shivanee-p
pushed a commit
that referenced
this pull request
Mar 27, 2026
* Fix parsing for qualifiers with colon characters * Update ci.yaml * fix: Support names with no qualifier * revert: remove workflow_dispatch * fix: Update test to check null qualifiers instead of undefined * fix: Respect column names without qualifiers * fix: Clean up for lint errors * fix: Remove remaining trailing space * revert: "fix: Update test to check null qualifiers instead of undefined" This reverts commit 1275dd56cd8aea668703e1f83daecfd14d5199f6. * fix: Allow undefined qualifiers in ParsedColumn * test: Add test for qualifier names with colons --------- Co-authored-by: danieljbruce <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 6.0.0 is out!