Skip to content

logging: format timestamp value#1274

Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--1270
May 2, 2016
Merged

logging: format timestamp value#1274
callmehiphop merged 1 commit intogoogleapis:masterfrom
stephenplusplus:spp--1270

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus commented Apr 30, 2016

Fixes #1270

To Dos

  • Unit tests

@stephenplusplus stephenplusplus added auth api: logging Issues related to the Cloud Logging API. labels Apr 30, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2016
@coveralls
Copy link
Copy Markdown

coveralls commented May 2, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 1c5075d on stephenplusplus:spp--1270 into 7c71ec5 on GoogleCloudPlatform:master.

Comment thread lib/logging/entry.js
if (serializedEntry.timestamp) {
var ms = serializedEntry.timestamp.seconds * 1000;
ms += serializedEntry.timestamp.nanos / 1e6;
serializedEntry.timestamp = new Date(ms);

This comment was marked as spam.

@callmehiphop callmehiphop merged commit 7d8e203 into googleapis:master May 2, 2016
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 3, 2026
sofisl pushed a commit that referenced this pull request Feb 24, 2026
sofisl pushed a commit that referenced this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants