Skip to content

datastore: separated property names from operators#1069

Merged
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:query-params
Jan 19, 2016
Merged

datastore: separated property names from operators#1069
stephenplusplus merged 1 commit intogoogleapis:masterfrom
callmehiphop:query-params

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

Breaking changes ahead!

closes #1062
closes #1061

There are two methods within datastore that combine property names with operators when building queries, this PR moves the operators to a separate parameter.

@krisnye - If you don't mind, please take a look! :)

@callmehiphop callmehiphop added the api: datastore Issues related to the Datastore API. label Jan 19, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2016
Comment thread lib/datastore/query.js Outdated

This comment was marked as spam.

This comment was marked as spam.

set default filter operator to equals
@stephenplusplus
Copy link
Copy Markdown
Contributor

LGTM!

stephenplusplus added a commit that referenced this pull request Jan 19, 2016
datastore: separated property names from operators
@stephenplusplus stephenplusplus merged commit ed30ea6 into googleapis:master Jan 19, 2016
@krisnye
Copy link
Copy Markdown

krisnye commented Jan 21, 2016

Looks good. Impressed by the quick response and fix.

sofisl pushed a commit that referenced this pull request Jan 17, 2023
* build(samples test): added imageContext to ImprovedRequest

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 25, 2026
* feat(signed-url): support list bucket (#1051)

* refactor signed url logic into its own class

* fix the test

* refactor tests to test/signer.ts

* npm run fix

* chore: generate synth.metadata

* allow bucket-operation signed url

* remove unused types

* support bucket operations

* refactor signer to not use promisify

* fix node-8 test

* add test for generation parameter

* test: add list bucket signed url system-test

* npm run fix

* fix bucket getSignedUrl docs

* chore(deps): update dependency @types/mocha to v7

* fix: unhandled promise rejection warning in samples (#1056)

* fix: unhandledPromiseRejectionWarning in samples

* fix: lint issue

* fix: lint issue

Co-authored-by: Benjamin E. Coe <[email protected]>

* docs(readme): log errors in sample

* chore: skip img.shields.io in docs test

Co-authored-by: Yoshi Automation Bot <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Lalji Kanjareeya <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>

* test(signed-url): update conformance test json to conformance-test@9f134282 (#1066)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): trailing `/` after path before query params (#1068)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* fix(signed-url): trailing `/` after path before query params

* fix(signed-url): fix query parameter signing (#1069)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): include custom query parameters in signature calculation

* query param wip

* fix queryParam sorting

* test: query params are sorted

* remove unused imports

* npm run fix

* refactor

* rename QueryParams to just Query

* feat(signed-url): support virtual hosted style url (#1067)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* vhost

* unit tests

* npm run fix

* docs: document urlStyle option for Bucket

* test: add system-test to exercise virtual-hosted url

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* restyle option as virtualHostedStyle as a boolean

* npm run fix

* docs: virtualHostedStyle option defaults to false

* docs: fix path style example

* fix: resource path beginning with /

* feat(signed-url): support SHA256 for signed payloads (#1070)

* feat(signed-url): support SHA256 for signed payloads

* add unit test

* remove junk import

* newline

* document contentMd5 option

* do not provide contentSha256 option, instead, detect user provided header

* npm run fix

* fix system-test

* test: expand URLSigner test

* fix(refactor): rename UrlSigner to URLSigner

* localize URLSigner unit tests

* address PR comments

* npm run fix

Co-authored-by: Yoshi Automation Bot <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Lalji Kanjareeya <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>
thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
* feat(signed-url): support list bucket (googleapis#1051)

* refactor signed url logic into its own class

* fix the test

* refactor tests to test/signer.ts

* npm run fix

* chore: generate synth.metadata

* allow bucket-operation signed url

* remove unused types

* support bucket operations

* refactor signer to not use promisify

* fix node-8 test

* add test for generation parameter

* test: add list bucket signed url system-test

* npm run fix

* fix bucket getSignedUrl docs

* chore(deps): update dependency @types/mocha to v7

* fix: unhandled promise rejection warning in samples (googleapis#1056)

* fix: unhandledPromiseRejectionWarning in samples

* fix: lint issue

* fix: lint issue

Co-authored-by: Benjamin E. Coe <[email protected]>

* docs(readme): log errors in sample

* chore: skip img.shields.io in docs test

Co-authored-by: Yoshi Automation Bot <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Lalji Kanjareeya <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>

* test(signed-url): update conformance test json to conformance-test@9f134282 (googleapis#1066)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): trailing `/` after path before query params (googleapis#1068)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* fix(signed-url): trailing `/` after path before query params

* fix(signed-url): fix query parameter signing (googleapis#1069)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): include custom query parameters in signature calculation

* query param wip

* fix queryParam sorting

* test: query params are sorted

* remove unused imports

* npm run fix

* refactor

* rename QueryParams to just Query

* feat(signed-url): support virtual hosted style url (googleapis#1067)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* vhost

* unit tests

* npm run fix

* docs: document urlStyle option for Bucket

* test: add system-test to exercise virtual-hosted url

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* restyle option as virtualHostedStyle as a boolean

* npm run fix

* docs: virtualHostedStyle option defaults to false

* docs: fix path style example

* fix: resource path beginning with /

* feat(signed-url): support SHA256 for signed payloads (googleapis#1070)

* feat(signed-url): support SHA256 for signed payloads

* add unit test

* remove junk import

* newline

* document contentMd5 option

* do not provide contentSha256 option, instead, detect user provided header

* npm run fix

* fix system-test

* test: expand URLSigner test

* fix(refactor): rename UrlSigner to URLSigner

* localize URLSigner unit tests

* address PR comments

* npm run fix

Co-authored-by: Yoshi Automation Bot <[email protected]>
Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Lalji Kanjareeya <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Justin Beckwith <[email protected]>
GautamSharda pushed a commit that referenced this pull request Mar 23, 2026
GautamSharda pushed a commit that referenced this pull request Mar 25, 2026
shivanee-p pushed a commit that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

4 participants