-
Notifications
You must be signed in to change notification settings - Fork 666
Translate API usage #2505
Copy link
Copy link
Closed
Labels
api: translateIssues related to the Cloud Translation API.Issues related to the Cloud Translation API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
api: translateIssues related to the Cloud Translation API.Issues related to the Cloud Translation API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Environment details
OS: Mac OS 10.12.6
Node.js version: 6.11.0
npm version: 3.10.10
google-cloud-node version: 1.0.0
Steps to reproduce
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/translate-1.0.0/packages/translate/src/index.js#L371 and https://github.com/GoogleCloudPlatform/google-cloud-node/blob/translate-1.0.0/packages/translate/src/index.js#L410
This is causing inconsistency in returning messages via the API. For example,
In other case like
I think this line https://github.com/GoogleCloudPlatform/google-cloud-node/blob/translate-1.0.0/packages/translate/src/index.js#L410 should rely on the default input instead of arrify version to return correctly data to the caller