Skip to content

Commit fc34f2f

Browse files
committed
updating system-tests
1 parent 36458f4 commit fc34f2f

2 files changed

Lines changed: 9 additions & 42 deletions

File tree

packages/bigtable/system-test/bigtable.js

Lines changed: 8 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -412,44 +412,13 @@ describe('Bigtable', function() {
412412
}
413413
}];
414414

415-
TABLE.insert(rows, function(err, entries) {
415+
TABLE.insert(rows, function(err, insertErrors) {
416416
assert.ifError(err);
417-
assert.strictEqual(entries.length, rows.length);
417+
assert.strictEqual(insertErrors.length, 0);
418418
done();
419419
});
420420
});
421421

422-
it('should not encode the values', function(done) {
423-
var message = 'hey';
424-
var encoded = new Buffer(message).toString('base64');
425-
426-
var rows = [{
427-
key: 'alincoln',
428-
data: {
429-
traits: {
430-
test: encoded
431-
}
432-
}
433-
}];
434-
435-
var options = {
436-
encode: false
437-
};
438-
439-
TABLE.insert(rows, options, function(err, entries) {
440-
assert.ifError(err);
441-
assert.strictEqual(entries.length, rows.length);
442-
443-
TABLE.row('alincoln').get(function(err, row) {
444-
assert.ifError(err);
445-
446-
var response = row.data.traits.test[0].value;
447-
assert.strictEqual(response, message);
448-
done();
449-
});
450-
});
451-
});
452-
453422
it('should create an individual row', function(done) {
454423
var row = TABLE.row('alincoln');
455424
var rowData = {
@@ -530,14 +499,12 @@ describe('Bigtable', function() {
530499
value: 'alincoln'
531500
};
532501

533-
var options = {
534-
onNoMatch: [{
535-
method: 'delete',
536-
data: ['follows:lincoln']
537-
}]
538-
};
502+
var mutations = [{
503+
method: 'delete',
504+
data: ['follows:alincoln']
505+
}];
539506

540-
row.filter(filter, options, function(err, matched) {
507+
row.filter(filter, mutations, function(err, matched) {
541508
assert.ifError(err);
542509
assert(matched);
543510
done();
@@ -605,7 +572,7 @@ describe('Bigtable', function() {
605572

606573
assert(presidents.length > 0);
607574

608-
Object.keys(presidents).forEach(function(prez) {
575+
presidents.forEach(function(prez) {
609576
var follower = row.data.follows[prez];
610577

611578
assert.strictEqual(follower[0].value, 'AAAAAAAAAAE=');

packages/bigtable/test/table.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -925,7 +925,7 @@ describe('Bigtable/Table', function() {
925925

926926
it('should emit a mutation error as an error event', function(done) {
927927
var mutationErrors = [];
928-
var emitter = table.mutate(entries)
928+
var emitter = table.mutate(entries);
929929

930930
assert(emitter instanceof events.EventEmitter);
931931

0 commit comments

Comments
 (0)