Skip to content

Commit e9549b1

Browse files
language: use gax
1 parent 0f8d832 commit e9549b1

5 files changed

Lines changed: 134 additions & 142 deletions

File tree

packages/language/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,8 @@
5656
"arrify": "^1.0.1",
5757
"extend": "^3.0.0",
5858
"google-gax": "^0.7.0",
59-
"google-proto-files": "^0.8.0",
6059
"is": "^3.0.1",
61-
"propprop": "^0.3.1",
62-
"string-format-obj": "^1.0.0"
60+
"propprop": "^0.3.1"
6361
},
6462
"devDependencies": {
6563
"@google-cloud/storage": "*",

packages/language/src/document.js

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ var prop = require('propprop');
6868
function Document(language, config) {
6969
var content = config.content || config;
7070

71-
// `reqOpts` is the payload passed to each `request()`. This object is used as
71+
this.api = language.api;
72+
73+
// `reqOpts` is the payload passed to each API request. This object is used as
7274
// the default for all API requests made with this Document.
7375
this.reqOpts = {
7476
document: {}
@@ -102,8 +104,6 @@ function Document(language, config) {
102104
} else {
103105
this.reqOpts.document.content = content;
104106
}
105-
106-
this.request = language.request.bind(language);
107107
}
108108

109109
/**
@@ -392,16 +392,10 @@ Document.prototype.annotate = function(options, callback) {
392392

393393
var verbose = options.verbose === true;
394394

395-
var grpcOpts = {
396-
service: 'LanguageService',
397-
method: 'annotateText'
398-
};
399-
400-
var reqOpts = extend({
401-
features: features
402-
}, this.reqOpts);
395+
var doc = this.reqOpts.document;
396+
var encType = this.reqOpts.encodingType;
403397

404-
this.request(grpcOpts, reqOpts, function(err, resp) {
398+
this.api.Language.annotateText(doc, features, encType, function(err, resp) {
405399
if (err) {
406400
callback(err, null, resp);
407401
return;
@@ -542,12 +536,10 @@ Document.prototype.detectEntities = function(options, callback) {
542536

543537
var verbose = options.verbose === true;
544538

545-
var grpcOpts = {
546-
service: 'LanguageService',
547-
method: 'analyzeEntities'
548-
};
539+
var doc = this.reqOpts.document;
540+
var encType = this.reqOpts.encodingType;
549541

550-
this.request(grpcOpts, this.reqOpts, function(err, resp) {
542+
this.api.Language.analyzeEntities(doc, encType, function(err, resp) {
551543
if (err) {
552544
callback(err, null, resp);
553545
return;
@@ -610,12 +602,10 @@ Document.prototype.detectSentiment = function(options, callback) {
610602

611603
var verbose = options.verbose === true;
612604

613-
var grpcOpts = {
614-
service: 'LanguageService',
615-
method: 'analyzeSentiment'
616-
};
605+
var doc = this.reqOpts.document;
606+
var encType = this.reqOpts.encodingType;
617607

618-
this.request(grpcOpts, this.reqOpts, function(err, resp) {
608+
this.api.Language.analyzeSentiment(doc, encType, function(err, resp) {
619609
if (err) {
620610
callback(err, null, resp);
621611
return;

packages/language/src/index.js

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@
2222

2323
var common = require('@google-cloud/common');
2424
var extend = require('extend');
25-
var googleProtoFiles = require('google-proto-files');
2625
var is = require('is');
27-
var util = require('util');
26+
var v1beta1 = require('./v1beta1');
2827

2928
/**
3029
* @type {module:language/document}
@@ -64,27 +63,11 @@ function Language(options) {
6463
return new Language(options);
6564
}
6665

67-
var config = {
68-
baseUrl: 'language.googleapis.com',
69-
service: 'language',
70-
apiVersion: 'v1beta1',
71-
protoServices: {
72-
LanguageService: {
73-
path: googleProtoFiles.language.v1beta1,
74-
service: 'cloud.language'
75-
}
76-
},
77-
scopes: [
78-
'https://www.googleapis.com/auth/cloud-platform'
79-
],
80-
packageJson: require('../package.json')
66+
this.api = {
67+
Language: v1beta1(options).languageServiceApi(options)
8168
};
82-
83-
common.GrpcService.call(this, config, options);
8469
}
8570

86-
util.inherits(Language, common.GrpcService);
87-
8871
/**
8972
* Run an annotation of a block of text.
9073
*
@@ -478,4 +461,4 @@ Language.prototype.text = function(content, options) {
478461
};
479462

480463
module.exports = Language;
481-
module.exports.v1beta1 = require('./v1beta1');
464+
module.exports.v1beta1 = v1beta1;

0 commit comments

Comments
 (0)