Skip to content

Commit e3fb6ad

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: [batch] Clarify Batch API proto doc about pubsub notifications (#4518)
* feat: Clarify Batch API proto doc about pubsub notifications --- feat: add Batch Managed Container support for v1alpha PiperOrigin-RevId: 554850516 Source-Link: googleapis/googleapis@28b8748 Source-Link: googleapis/googleapis-gen@69f99df Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhdGNoLy5Pd2xCb3QueWFtbCIsImgiOiI2OWY5OWRmM2EwM2ViZGMxZGQwMjY1YmQzZDk5YjNlZDQ5ZGM1N2NkIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 0f6b33d commit e3fb6ad

5 files changed

Lines changed: 52 additions & 4 deletions

File tree

‎packages/google-cloud-batch/protos/google/cloud/batch/v1alpha/job.proto‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,12 @@ message ResourceUsage {
243243
// Notification configurations.
244244
message JobNotification {
245245
// Message details.
246-
// Describe the attribute that a message should have.
247-
// Without specified message attributes, no message will be sent by default.
246+
// Describe the conditions under which messages will be sent.
247+
// If no attribute is defined, no message will be sent by default.
248+
// One message should specify either the job or the task level attributes,
249+
// but not both. For example,
250+
// job level: JOB_STATE_CHANGED and/or a specified new_job_state;
251+
// task level: TASK_STATE_CHANGED and/or a specified new_task_state.
248252
message Message {
249253
// The message type.
250254
Type type = 1;
@@ -269,8 +273,8 @@ message JobNotification {
269273
}
270274

271275
// The Pub/Sub topic where notifications like the job state changes
272-
// will be published. This topic exist in the same project as the job
273-
// and billings will be charged to this project.
276+
// will be published. The topic must exist in the same project as
277+
// the job and billings will be charged to this project.
274278
// If not specified, no Pub/Sub messages will be sent.
275279
// Topic format: `projects/{project}/topics/{topic}`.
276280
string pubsub_topic = 1;

‎packages/google-cloud-batch/protos/google/cloud/batch/v1alpha/task.proto‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ syntax = "proto3";
1616

1717
package google.cloud.batch.v1alpha;
1818

19+
import "google/api/field_behavior.proto";
1920
import "google/api/resource.proto";
2021
import "google/cloud/batch/v1alpha/volume.proto";
2122
import "google/protobuf/duration.proto";
@@ -156,6 +157,13 @@ message Runnable {
156157
// matches `projects/*/secrets/*/versions/*` then Batch will read the
157158
// password from the Secret Manager;
158159
string password = 11;
160+
161+
// Optional. Not yet implemented.
162+
// If set to true, container will run with Image streaming.
163+
// The container runtime will be changed to containerd
164+
// instead of docker. Currently, only imageUri, commands, entrypoint
165+
// and volumes are supported and any other fields will be ignored.
166+
bool enable_image_streaming = 12 [(google.api.field_behavior) = OPTIONAL];
159167
}
160168

161169
// Script runnable.

‎packages/google-cloud-batch/protos/protos.d.ts‎

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-batch/protos/protos.js‎

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-batch/protos/protos.json‎

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)