pr feedback

callmehiphop · callmehiphop · commit da4e45fafd71 · 2017-03-10T15:25:41.000-05:00
diff --git a/packages/spanner/test/session-pool.js b/packages/spanner/test/session-pool.js
@@ -1563,7 +1563,7 @@ describe('SessionEvictor', function() {
       sessionEvictor.evict(CONFIG, RESOURCE, AVAILABLE);
     });
 
-    it('should run a query & update evicted status on session', function(done) {
+    it('should set evicted to true when a session expires', function(done) {
       sessionEvictor.evictor.evict = function() {
         return true;
       };
@@ -1580,6 +1580,23 @@ describe('SessionEvictor', function() {
       sessionEvictor.evict(CONFIG, RESOURCE, AVAILABLE);
     });
 
+    it('should set evicted to false when sessions dont expire', function(done) {
+      sessionEvictor.evictor.evict = function() {
+        return true;
+      };
+
+      RESOURCE.obj.keepAlive = function(callback) {
+        callback(null);
+
+        setImmediate(function() {
+          assert.strictEqual(RESOURCE.obj.evicted_, false);
+          done();
+        });
+      };
+
+      sessionEvictor.evict(CONFIG, RESOURCE, AVAILABLE);
+    });
+
     it('should return false if still active', function() {
       var evictReturnValue = sessionEvictor.evict(CONFIG, RESOURCE, AVAILABLE);
       assert.strictEqual(evictReturnValue, false);
diff --git a/packages/spanner/test/session.js b/packages/spanner/test/session.js
@@ -232,7 +232,7 @@ describe('Session', function() {
   });
 
   describe('keepAlive', function() {
-    it('should correctl call and return the gax API', function() {
+    it('should correctly call and return the gax API', function() {
       var gaxReturnValue = {};
 
       function callback() {}
