feat: [batch] Clarify Batch API proto doc about pubsub notifications (#4503)

gcf-owl-bot[bot] · web-flow · commit ca2296c5d180 · 2023-08-07T19:34:53.000-07:00
* feat: Clarify Batch API proto doc about pubsub notifications --- feat: add Batch Managed Container support for v1alpha PiperOrigin-RevId: 554622486 Source-Link: googleapis/googleapis@0e42ad0 Source-Link: googleapis/googleapis-gen@274d7b7 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhdGNoLy5Pd2xCb3QueWFtbCIsImgiOiIyNzRkN2I3NzdlNDRkMmUwNjBlZTBkY2EzNjIwNDExOTI3NWMyZGNhIn0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/packages/google-cloud-batch/protos/google/cloud/batch/v1/job.proto b/packages/google-cloud-batch/protos/google/cloud/batch/v1/job.proto
@@ -184,8 +184,12 @@ message JobStatus {
 // Notification configurations.
 message JobNotification {
   // Message details.
-  // Describe the attribute that a message should have.
-  // Without specified message attributes, no message will be sent by default.
+  // Describe the conditions under which messages will be sent.
+  // If no attribute is defined, no message will be sent by default.
+  // One message should specify either the job or the task level attributes,
+  // but not both. For example,
+  // job level: JOB_STATE_CHANGED and/or a specified new_job_state;
+  // task level: TASK_STATE_CHANGED and/or a specified new_task_state.
   message Message {
     // The message type.
     Type type = 1;
@@ -210,8 +214,8 @@ message JobNotification {
   }
 
   // The Pub/Sub topic where notifications like the job state changes
-  // will be published. This topic exist in the same project as the job
-  // and billings will be charged to this project.
+  // will be published. The topic must exist in the same project as
+  // the job and billings will be charged to this project.
   // If not specified, no Pub/Sub messages will be sent.
   // Topic format: `projects/{project}/topics/{topic}`.
   string pubsub_topic = 1;
diff --git a/packages/google-cloud-batch/protos/google/cloud/batch/v1/task.proto b/packages/google-cloud-batch/protos/google/cloud/batch/v1/task.proto
@@ -16,6 +16,7 @@ syntax = "proto3";
 
 package google.cloud.batch.v1;
 
+import "google/api/field_behavior.proto";
 import "google/api/resource.proto";
 import "google/cloud/batch/v1/volume.proto";
 import "google/protobuf/duration.proto";
diff --git a/packages/google-cloud-batch/samples/generated/v1/snippet_metadata.google.cloud.batch.v1.json b/packages/google-cloud-batch/samples/generated/v1/snippet_metadata.google.cloud.batch.v1.json
@@ -1,7 +1,7 @@
 {
     "clientLibrary": {
         "name": "nodejs-batch",
-        "version": "0.10.0",
+        "version": "1.0.0",
         "language": "TYPESCRIPT",
         "apis": [
             {
diff --git a/packages/google-cloud-batch/samples/generated/v1/snippet_metadata_google.cloud.batch.v1.json b/packages/google-cloud-batch/samples/generated/v1/snippet_metadata_google.cloud.batch.v1.json
@@ -1,7 +1,7 @@
 {
     "clientLibrary": {
         "name": "nodejs-batch",
-        "version": "0.10.0",
+        "version": "1.0.0",
         "language": "TYPESCRIPT",
         "apis": [
             {
diff --git a/packages/google-cloud-batch/samples/generated/v1alpha/snippet_metadata.google.cloud.batch.v1alpha.json b/packages/google-cloud-batch/samples/generated/v1alpha/snippet_metadata.google.cloud.batch.v1alpha.json
@@ -1,7 +1,7 @@
 {
     "clientLibrary": {
         "name": "nodejs-batch",
-        "version": "0.10.0",
+        "version": "1.0.0",
         "language": "TYPESCRIPT",
         "apis": [
             {
diff --git a/packages/google-cloud-batch/samples/generated/v1alpha/snippet_metadata_google.cloud.batch.v1alpha.json b/packages/google-cloud-batch/samples/generated/v1alpha/snippet_metadata_google.cloud.batch.v1alpha.json
@@ -1,7 +1,7 @@
 {
     "clientLibrary": {
         "name": "nodejs-batch",
-        "version": "0.10.0",
+        "version": "1.0.0",
         "language": "TYPESCRIPT",
         "apis": [
             {

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"clientLibrary": {`
`3`	`3`	`"name": "nodejs-batch",`
`4`		`- "version": "0.10.0",`
	`4`	`+ "version": "1.0.0",`
`5`	`5`	`"language": "TYPESCRIPT",`
`6`	`6`	`"apis": [`
`7`	`7`	`{`