Skip to content

Commit c2976aa

Browse files
feat: [gkehub] add k8s_git_version field (#6721)
* feat: add `k8s_git_version` field docs: correct comment for `k8s_version` field The new field `k8s_git_version` captures the full Kubernetes version string for a membership. PiperOrigin-RevId: 805935629 Source-Link: googleapis/googleapis@780e612 Source-Link: googleapis/googleapis-gen@d0c6d1d Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWdrZWh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDBjNmQxZGY0ZjQ2MDI1ZWMwMTYwYTRhY2ZlMjRlOGVhZjM2MWRhYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 62b6bae commit c2976aa

5 files changed

Lines changed: 88 additions & 6 deletions

File tree

packages/google-cloud-gkehub/protos/google/cloud/gkehub/v1/membership.proto

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,15 @@ message ResourceOptions {
188188
// <1.16.
189189
bool v1beta1_crd = 2 [(google.api.field_behavior) = OPTIONAL];
190190

191-
// Optional. Major version of the Kubernetes cluster. This is only used to
192-
// determine which version to use for the CustomResourceDefinition resources,
193-
// `apiextensions/v1beta1` or`apiextensions/v1`.
191+
// Optional. Major and minor version of the Kubernetes cluster. This is only
192+
// used to determine which version to use for the CustomResourceDefinition
193+
// resources, `apiextensions/v1beta1` or`apiextensions/v1`.
194194
string k8s_version = 3 [(google.api.field_behavior) = OPTIONAL];
195+
196+
// Optional. Git version of the Kubernetes cluster. This is only used to gate
197+
// the Connect Agent migration to svc.id.goog on GDC-SO 1.33.100 patch and
198+
// above.
199+
string k8s_git_version = 4 [(google.api.field_behavior) = OPTIONAL];
195200
}
196201

197202
// ResourceManifest represents a single Kubernetes resource to be applied to

packages/google-cloud-gkehub/protos/google/cloud/gkehub/v1beta1/membership.proto

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,15 @@ message ResourceOptions {
352352
// <1.16.
353353
bool v1beta1_crd = 2 [(google.api.field_behavior) = OPTIONAL];
354354

355-
// Optional. Major version of the Kubernetes cluster. This is only used to
356-
// determine which version to use for the CustomResourceDefinition resources,
357-
// `apiextensions/v1beta1` or`apiextensions/v1`.
355+
// Optional. Major and minor version of the Kubernetes cluster. This is only
356+
// used to determine which version to use for the CustomResourceDefinition
357+
// resources, `apiextensions/v1beta1` or`apiextensions/v1`.
358358
string k8s_version = 3 [(google.api.field_behavior) = OPTIONAL];
359+
360+
// Optional. Git version of the Kubernetes cluster. This is only used to gate
361+
// the Connect Agent migration to svc.id.goog on GDC-SO 1.33.100 patch and
362+
// above.
363+
string k8s_git_version = 4 [(google.api.field_behavior) = OPTIONAL];
359364
}
360365

361366
// ResourceManifest represents a single Kubernetes resource to be applied to

packages/google-cloud-gkehub/protos/protos.d.ts

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-gkehub/protos/protos.js

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-cloud-gkehub/protos/protos.json

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)