Merge branch 'master' into speech

jmuk · jmuk · commit b9507ef32446 · 2016-09-26T14:17:01.000-07:00
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -32,6 +32,7 @@ install:
       if (!$env:APPVEYOR_PULL_REQUEST_NUMBER) {
         nuget install secure-file -ExcludeVersion
         secure-file\tools\secure-file -decrypt key.appveyor.json.enc -secret $env:GCLOUD_TESTS_KEY_SECRET
+        set GCLOUD_TESTS_KEY=%cd%\%GCLOUD_TESTS_KEY%
       }
   - npm install -g npm
   - set PATH=%APPDATA%\npm;%PATH%
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -3,7 +3,7 @@ Thanks for stopping by to let us know something could be better!
 Please run down the following list and make sure you've tried the usual "quick fixes":
 
   - Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
-  - Search StackOverflow: https://stackoverflow.com/questions/tagged/gcloud-node
+  - Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
   - Check our Troubleshooting guide: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/troubleshooting
   - Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/faq
 
diff --git a/.travis.yml b/.travis.yml
@@ -34,6 +34,7 @@ before_script:
     fi
   - if [ $IS_PUSH_TO_MASTER ]; then
       openssl aes-256-cbc -K $encrypted_b8aa0887832a_key -iv $encrypted_b8aa0887832a_iv -in key.json.enc -out key.json -d;
+      export GCLOUD_TESTS_KEY="$(pwd)/key.json";
     fi
 script: "node ./scripts/build.js"
 after_success:
diff --git a/docs/home.html b/docs/home.html
@@ -39,7 +39,7 @@ <h4 class="latest-release subtle" ng-if="home.latestRelease">
         </a>
       </li>
       <li>
-        <a href="http://stackoverflow.com/questions/tagged/google-cloud" title="google-cloud on StackOverflow" class="ext-link">
+        <a href="http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js" title="google-cloud on StackOverflow" class="ext-link">
           <img src="src/images/icon-link-stackoverflow.svg" alt="StackOverflow icon" />
           StackOverflow
         </a>
diff --git a/package.json b/package.json
@@ -3,13 +3,15 @@
   "private": "true",
   "devDependencies": {
     "array-uniq": "^1.0.3",
-    "async": "^1.4.2",
+    "async": "^2.0.1",
     "coveralls": "^2.11.2",
     "create-error-class": "^3.0.2",
+    "david": "^9.0.0",
     "dox": "0.8.1",
     "extend": "^3.0.0",
     "glob": "^5.0.9",
     "globby": "^3.0.1",
+    "is": "^3.1.0",
     "istanbul": "^0.3.5",
     "jscs": "^2.1.1",
     "jshint": "^2.9.1",
@@ -18,6 +20,7 @@
     "mitm": "^1.1.0",
     "mkdirp": "^0.5.1",
     "mocha": "^2.5.3",
+    "package-json": "^2.4.0",
     "propprop": "^0.3.1",
     "proxyquire": "^1.7.10",
     "request": "^2.70.0",
@@ -28,6 +31,7 @@
   },
   "scripts": {
     "postinstall": "node ./scripts/install.js",
+    "update-deps": "node ./scripts/update-deps.js",
     "docs": "node ./scripts/docs/packages.js",
     "bundle": "node ./scripts/docs/bundle.js",
     "lint": "jshint scripts/ packages/ system-test/ test/ && jscs packages/ system-test/ test/",
diff --git a/packages/bigtable/package.json b/packages/bigtable/package.json
@@ -56,7 +56,7 @@
     "create-error-class": "^3.0.2",
     "dot-prop": "^3.0.0",
     "extend": "^3.0.0",
-    "google-proto-files": "^0.7.0",
+    "google-proto-files": "^0.8.0",
     "is": "^3.0.1",
     "lodash.flatten": "^4.2.0",
     "node-int64": "^0.4.0",
diff --git a/packages/common/package.json b/packages/common/package.json
@@ -47,7 +47,7 @@
     "ent": "^2.2.0",
     "extend": "^3.0.0",
     "google-auto-auth": "^0.2.4",
-    "google-proto-files": "^0.7.0",
+    "google-proto-files": "^0.8.0",
     "grpc": "^1.0.0",
     "is": "^3.0.1",
     "methmeth": "^1.0.0",
diff --git a/packages/common/src/util.js b/packages/common/src/util.js
@@ -29,6 +29,7 @@ var googleAuth = require('google-auto-auth');
 var is = require('is');
 var request = require('request').defaults({
   timeout: 60000,
+  gzip: true,
   pool: {
     maxSockets: Infinity
   }
diff --git a/packages/common/test/util.js b/packages/common/test/util.js
@@ -95,6 +95,7 @@ describe('common/util', function() {
   it('should have set correct defaults on Request', function() {
     assert.deepEqual(REQUEST_DEFAULT_CONF, {
       timeout: 60000,
+      gzip: true,
       pool: {
         maxSockets: Infinity
       }
diff --git a/packages/compute/package.json b/packages/compute/package.json
@@ -52,8 +52,8 @@
   "dependencies": {
     "@google-cloud/common": "^0.5.0",
     "arrify": "^1.0.0",
-    "async": "^1.4.2",
-    "create-error-class": "^2.0.1",
+    "async": "^2.0.1",
+    "create-error-class": "^3.0.2",
     "extend": "^3.0.0",
     "gce-images": "^0.3.0",
     "is": "^3.0.1",
diff --git a/packages/datastore/src/entity.js b/packages/datastore/src/entity.js
@@ -191,7 +191,8 @@ function decodeValueProto(valueProto) {
     }
 
     case 'timestampValue': {
-      return new Date(parseInt(value.seconds, 10) * 1000);
+      var milliseconds = parseInt(value.nanos, 10) / 1e6;
+      return new Date(parseInt(value.seconds, 10) * 1000 + milliseconds);
     }
 
     default: {
@@ -252,11 +253,10 @@ function encodeValue(value) {
 
   if (value instanceof Date) {
     var seconds = value.getTime() / 1000;
-    var secondsRounded = Math.floor(seconds);
 
     valueProto.timestampValue = {
-      seconds: secondsRounded,
-      nanos: Math.floor((seconds - secondsRounded) * 1e9)
+      seconds: Math.floor(seconds),
+      nanos: value.getMilliseconds() * 1e6
     };
 
     return valueProto;
diff --git a/packages/datastore/system-test/datastore.js b/packages/datastore/system-test/datastore.js
@@ -71,7 +71,7 @@ describe('Datastore', function() {
     var post = {
       title: 'How to make the perfect pizza in your grill',
       tags: ['pizza', 'grill'],
-      publishedAt: new Date(2001, 0, 1),
+      publishedAt: new Date(),
       author: 'Silvano',
       isDraft: false,
       wordCount: 400,
diff --git a/packages/datastore/test/entity.js b/packages/datastore/test/entity.js
@@ -218,13 +218,18 @@ describe('entity', function() {
     });
 
     it('should decode timestamps', function() {
-      var seconds = String(Date.now() / 1000);
-      var expectedValue = new Date(parseInt(seconds, 10) * 1000);
+      var date = new Date();
+
+      var seconds = Math.floor(date.getTime() / 1000);
+      var ms = date.getMilliseconds();
+
+      var expectedValue = new Date(seconds * 1000 + ms);
 
       var valueProto = {
         value_type: 'timestampValue',
         timestampValue: {
-          seconds: seconds
+          seconds: seconds,
+          nanos: ms * 1e6
         }
       };
 
@@ -327,12 +332,11 @@ describe('entity', function() {
     it('should encode a date', function() {
       var value = new Date();
       var seconds = value.getTime() / 1000;
-      var secondsRounded = Math.floor(seconds);
 
       var expectedValueProto = {
         timestampValue: {
-          seconds: secondsRounded,
-          nanos: Math.floor((seconds - secondsRounded) * 1e9)
+          seconds: Math.floor(seconds),
+          nanos: value.getMilliseconds() * 1e6
         }
       };
 
diff --git a/packages/language/src/document.js b/packages/language/src/document.js
@@ -30,7 +30,6 @@ var prop = require('propprop');
 /*! Developer Documentation
  *
  * @param {module:language} language - The parent Language object.
- * @param {object=} config - Configuration object.
  */
 /*
  * Create a Natural Language Document object. From this object, you will be able
@@ -39,13 +38,32 @@ var prop = require('propprop');
  * @constructor
  * @alias module:language/document
  *
+ * @param {object|string|module:storage/file} config - Configuration object, the
+ *     inline content of the document, or a Storage File object.
+ * @param {string|module:storage/file} options.content - If using `config` as an
+ *     object to specify the encoding and/or language of the document, use this
+ *     property to pass the inline content of the document or a Storage File
+ *     object.
+ * @param {string} options.encoding - `UTF8`, `UTF16`, or `UTF32`. See
+ *     [`EncodingType`](https://cloud.google.com/natural-language/reference/rest/v1beta1/EncodingType).
+ * @param {string} options.language - The language of the text.
+ * @return {module:language/document}
+ *
  * @example
  * var textToAnalyze = [
  *   'Google is an American multinational technology company specializing in',
  *   'Internet-related services and products.'
  * ].join(' ');
  *
  * var document = language.document(textToAnalyze);
+ *
+ * //-
+ * // Create a Document object with pre-defined configuration, such as its
+ * // language.
+ * //-
+ * var spanishDocument = language.document('¿Dónde está la sede de Google?', {
+ *   language: 'es'
+ * });
  */
 function Document(language, config) {
   var content = config.content || config;
@@ -130,7 +148,8 @@ Document.PART_OF_SPEECH = {
  *
  * @resource [documents.annotateText API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/annotateText}
  *
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/annotateText#request-body).
  * @param {boolean} options.entities - Detect the entities from this document.
  *     By default, all features (`entities`, `sentiment`, and `syntax`) are
  *     enabled. By overriding any of these values, all defaults are switched to
@@ -419,7 +438,8 @@ Document.prototype.annotate = function(options, callback) {
  *
  * @resource [documents.analyzeEntities API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeEntities}
  *
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeEntities#request-body).
  * @param {boolean} options.verbose - Enable verbose mode for more detailed
  *     results. Default: `false`
  * @param {function} callback - The callback function.
@@ -545,7 +565,8 @@ Document.prototype.detectEntities = function(options, callback) {
  *
  * @resource [documents.analyzeSentiment API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeSentiment}
  *
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeSentiment#request-body).
  * @param {boolean} options.verbose - Enable verbose mode for more detailed
  *     results. Default: `false`
  * @param {function} callback - The callback function.
diff --git a/packages/language/src/index.js b/packages/language/src/index.js
@@ -93,11 +93,12 @@ util.inherits(Language, common.GrpcService);
  * detection, this may be more convenient. However, if you plan to run multiple
  * detections, it's easier to create a {module:language/document} object.
  *
- * @resource [documents.annotate API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/annotate}
+ * @resource [documents.annotate API Documentation]{@link https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/annotateText}
  *
  * @param {string|module:storage/file} content - Inline content or a Storage
  *     File object.
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/annotateText#request-body).
  * @param {string} options.encoding - `UTF8`, `UTF16`, or `UTF32`. See
  *     [`EncodingType`](https://cloud.google.com/natural-language/reference/rest/v1beta1/EncodingType).
  * @param {string} options.language - The language of the text.
@@ -136,6 +137,16 @@ util.inherits(Language, common.GrpcService);
  * language.annotate('Hello!', options, callback);
  *
  * //-
+ * // Specify the language the text is written in.
+ * //-
+ * var options = {
+ *   language: 'es',
+ *   entities: true
+ * };
+ *
+ * language.annotate('¿Dónde está la sede de Google?', options, callback);
+ *
+ * //-
  * // Verbose mode may also be enabled for more detailed results.
  * //-
  * var options = {
@@ -170,7 +181,8 @@ Language.prototype.annotate = function(content, options, callback) {
  *
  * @param {string|module:storage/file} content - Inline content or a Storage
  *     File object.
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeEntities#request-body).
  * @param {string} options.encoding - `UTF8`, `UTF16`, or `UTF32`. See
  *     [`EncodingType`](https://cloud.google.com/natural-language/reference/rest/v1beta1/EncodingType).
  * @param {string} options.language - The language of the text.
@@ -209,6 +221,15 @@ Language.prototype.annotate = function(content, options, callback) {
  * language.detectEntities('Axel Foley is from Detroit', options, callback);
  *
  * //-
+ * // Specify the language the text is written in.
+ * //-
+ * var options = {
+ *   language: 'es'
+ * };
+ *
+ * language.detectEntities('Axel Foley es de Detroit', options, callback);
+ *
+ * //-
  * // Verbose mode may also be enabled for more detailed results.
  * //-
  * var options = {
@@ -243,7 +264,8 @@ Language.prototype.detectEntities = function(content, options, callback) {
  *
  * @param {string|module:storage/file} content - Inline content or a Storage
  *     File object.
- * @param {object=} options - Configuration object.
+ * @param {object=} options - Configuration object. See
+ *     [documents.annotateText](https://cloud.google.com/natural-language/reference/rest/v1beta1/documents/analyzeSentiment#request-body).
  * @param {string} options.encoding - `UTF8`, `UTF16`, or `UTF32`. See
  *     [`EncodingType`](https://cloud.google.com/natural-language/reference/rest/v1beta1/EncodingType).
  * @param {string} options.language - The language of the text.
@@ -337,6 +359,14 @@ Language.prototype.detectSentiment = function(content, options, callback) {
  * var document = language.document(file);
  *
  * //-
+ * // Create a Document object with pre-defined configuration, such as its
+ * // language.
+ * //-
+ * var document = language.document('¿Dónde está la sede de Google?', {
+ *   language: 'es'
+ * });
+ *
+ * //-
  * // You can now run detections on the document.
  * //
  * // See {module:language/document} for a complete list of methods available.
@@ -374,6 +404,14 @@ Language.prototype.document = function(config) {
  * var document = language.html(file);
  *
  * //-
+ * // Create a Document object with pre-defined configuration, such as its
+ * // language.
+ * //-
+ * var document = language.html('&lt;h1>Titulo del documento&lt;/h1>', {
+ *   language: 'es'
+ * });
+ *
+ * //-
  * // You can now run detections on the document.
  * //
  * // See {module:language/document} for a complete list of methods available.
@@ -416,6 +454,14 @@ Language.prototype.html = function(content, options) {
  * var document = language.text(file);
  *
  * //-
+ * // Create a Document object with pre-defined configuration, such as its
+ * // language.
+ * //-
+ * var document = language.text('¿Dónde está la sede de Google?', {
+ *   language: 'es'
+ * });
+ *
+ * //-
  * // You can now run detections on the document.
  * //
  * // See {module:language/document} for a complete list of methods available.
diff --git a/packages/logging/package.json b/packages/logging/package.json
@@ -57,7 +57,7 @@
     "arrify": "^1.0.0",
     "extend": "^3.0.0",
     "google-gax": "^0.6.0",
-    "google-proto-files": "^0.7.0",
+    "google-proto-files": "^0.8.0",
     "is": "^3.0.1",
     "string-format-obj": "^1.0.0"
   },
diff --git a/packages/speech/package.json b/packages/speech/package.json
@@ -59,7 +59,7 @@
     "events-intercept": "^2.0.0",
     "extend": "^3.0.0",
     "google-gax": "^0.6.0",
-    "google-proto-files": "^0.7.0",
+    "google-proto-files": "^0.8.0",
     "is": "^3.1.0",
     "modelo": "^4.2.0",
     "propprop": "^0.3.1",
diff --git a/packages/storage/package.json b/packages/storage/package.json
@@ -52,9 +52,9 @@
   "dependencies": {
     "@google-cloud/common": "^0.5.0",
     "arrify": "^1.0.0",
-    "async": "^1.4.2",
+    "async": "^2.0.1",
     "concat-stream": "^1.5.0",
-    "create-error-class": "^2.0.1",
+    "create-error-class": "^3.0.2",
     "duplexify": "^3.2.0",
     "extend": "^3.0.0",
     "gcs-resumable-upload": "^0.7.1",
diff --git a/packages/vision/package.json b/packages/vision/package.json
diff --git a/packages/vision/system-test/vision.js b/packages/vision/system-test/vision.js
diff --git a/scripts/helpers.js b/scripts/helpers.js
diff --git a/scripts/update-deps.js b/scripts/update-deps.js
diff --git a/test/docs.js b/test/docs.js

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ install:`
`32`	`32`	`if (!$env:APPVEYOR_PULL_REQUEST_NUMBER) {`
`33`	`33`	`nuget install secure-file -ExcludeVersion`
`34`	`34`	`secure-file\tools\secure-file -decrypt key.appveyor.json.enc -secret $env:GCLOUD_TESTS_KEY_SECRET`
	`35`	`+ set GCLOUD_TESTS_KEY=%cd%\%GCLOUD_TESTS_KEY%`
`35`	`36`	`}`
`36`	`37`	`- npm install -g npm`
`37`	`38`	`- set PATH=%APPDATA%\npm;%PATH%`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ var googleAuth = require('google-auto-auth');`
`29`	`29`	`var is = require('is');`
`30`	`30`	`var request = require('request').defaults({`
`31`	`31`	`timeout: 60000,`
	`32`	`+ gzip: true,`
`32`	`33`	`pool: {`
`33`	`34`	`maxSockets: Infinity`
`34`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ describe('common/util', function() {`
`95`	`95`	`it('should have set correct defaults on Request', function() {`
`96`	`96`	`assert.deepEqual(REQUEST_DEFAULT_CONF, {`
`97`	`97`	`timeout: 60000,`
	`98`	`+ gzip: true,`
`98`	`99`	`pool: {`
`99`	`100`	`maxSockets: Infinity`
`100`	`101`	`}`