gcs-resumable-upload now supports providing an offset

Ben Stahl · stephenplusplus · commit b877420090c4 · 2016-05-18T07:53:57.000-04:00
diff --git a/lib/storage/bucket.js b/lib/storage/bucket.js
@@ -938,6 +938,8 @@ Bucket.prototype.makePublic = function(options, callback) {
  *     `options.metadata.contentEncoding` to `gzip`.
  * @param {object} options.metadata - See an
  *     [Objects: insert request body](https://cloud.google.com/storage/docs/json_api/v1/objects/insert#request_properties_JSON).
+ * @param {string} options.offset - The starting byte of the upload stream, for
+ *     resuming an interrupted upload. Defaults to 0.
  * @param {string} options.predefinedAcl - Apply a predefined set of access
  *     controls to this object.
  *
diff --git a/lib/storage/file.js b/lib/storage/file.js
@@ -719,10 +719,8 @@ File.prototype.createResumableUpload = function(options, callback) {
  *     `options.metadata.contentEncoding` to `gzip`.
  * @param {object=} options.metadata - See an
  *     [Objects: insert request body](https://cloud.google.com/storage/docs/json_api/v1/objects/insert#request_properties_JSON).
- * @param {boolean} options.resumable - Force a resumable upload. NOTE: When
- *     working with streams, the file format and size is unknown until it's
- *     completely consumed. Because of this, it's best for you to be explicit
- *     for what makes sense given your input.
+ * @param {string} options.offset - The starting byte of the upload stream, for
+ *     resuming an interrupted upload. Defaults to 0.
  * @param {string} options.predefinedAcl - Apply a predefined set of access
  *     controls to this object.
  *
@@ -747,6 +745,10 @@ File.prototype.createResumableUpload = function(options, callback) {
  *     `options.predefinedAcl = 'private'`)
  * @param {boolean} options.public - Make the uploaded file public. (Alias for
  *     `options.predefinedAcl = 'publicRead'`)
+ * @param {boolean} options.resumable - Force a resumable upload. NOTE: When
+ *     working with streams, the file format and size is unknown until it's
+ *     completely consumed. Because of this, it's best for you to be explicit
+ *     for what makes sense given your input.
  * @param {string} options.uri - The URI for an already-created resumable
  *     upload. See {module:storage/file#createResumableUpload}.
  * @param {string|boolean} options.validation - Possible values: `"md5"`,
@@ -1547,6 +1549,7 @@ File.prototype.startResumableUpload_ = function(dup, options) {
     file: this.name,
     generation: this.generation,
     metadata: options.metadata,
+    offset: options.offset,
     predefinedAcl: options.predefinedAcl,
     private: options.private,
     public: options.public,
diff --git a/test/storage/file.js b/test/storage/file.js
@@ -2180,6 +2180,7 @@ describe('File', function() {
       it('should start a resumable upload', function(done) {
         var options = {
           metadata: {},
+          offset: 1234,
           public: true,
           private: false,
           predefinedAcl: 'allUsers',
@@ -2198,6 +2199,7 @@ describe('File', function() {
           assert.strictEqual(opts.file, file.name);
           assert.strictEqual(opts.generation, file.generation);
           assert.strictEqual(opts.metadata, options.metadata);
+          assert.strictEqual(opts.offset, options.offset);
           assert.strictEqual(opts.predefinedAcl, options.predefinedAcl);
           assert.strictEqual(opts.private, options.private);
           assert.strictEqual(opts.public, options.public);

Original file line number	Diff line number	Diff line change
`@@ -938,6 +938,8 @@ Bucket.prototype.makePublic = function(options, callback) {`
`938`	`938`	* `options.metadata.contentEncoding` to `gzip`.
`939`	`939`	`* @param {object} options.metadata - See an`
`940`	`940`	`* [Objects: insert request body](https://cloud.google.com/storage/docs/json_api/v1/objects/insert#request_properties_JSON).`
	`941`	`+ * @param {string} options.offset - The starting byte of the upload stream, for`
	`942`	`+ * resuming an interrupted upload. Defaults to 0.`
`941`	`943`	`* @param {string} options.predefinedAcl - Apply a predefined set of access`
`942`	`944`	`* controls to this object.`
`943`	`945`	`*`