Skip to content

Commit ad27ba7

Browse files
gcf-owl-bot[bot]sofisl
gcf-owl-bot[bot]
and
sofisl
authored
fix: [retail] fix the HTTP format for merchant center link service (#4183)
* fix: fix the HTTP format for merchant center link service PiperOrigin-RevId: 524889384 Source-Link: googleapis/googleapis@5b42ea6 Source-Link: googleapis/googleapis-gen@2aa53eb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXJldGFpbC8uT3dsQm90LnlhbWwiLCJoIjoiMmFhNTNlYjQ3ZTM0OWIxMDFlMDdkNmU5MzIxYzc0NmFhMDI0MThhYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]>
1 parent 8d2de8c commit ad27ba7

7 files changed

Lines changed: 29 additions & 38 deletions

‎packages/google-cloud-retail/protos/google/cloud/retail/v2alpha/merchant_center_account_link_service.proto‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,12 @@ service MerchantCenterAccountLinkService {
5050
option (google.api.method_signature) = "parent";
5151
}
5252

53-
// Creates a MerchantCenterAccountLink.
54-
//
55-
// [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink]
56-
// cannot be set to a different oneof field, if so an INVALID_ARGUMENT is
57-
// returned.
53+
// Creates a
54+
// [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink].
5855
rpc CreateMerchantCenterAccountLink(CreateMerchantCenterAccountLinkRequest)
5956
returns (google.longrunning.Operation) {
6057
option (google.api.http) = {
61-
post: "/v2alpha/{merchant_center_account_link.name=projects/*/locations/*/catalogs/*/merchantCenterAccountLinks/*}"
58+
post: "/v2alpha/{parent=projects/*/locations/*/catalogs/*}/merchantCenterAccountLinks"
6259
body: "merchant_center_account_link"
6360
};
6461
option (google.api.method_signature) =
@@ -69,7 +66,8 @@ service MerchantCenterAccountLinkService {
6966
};
7067
}
7168

72-
// Deletes a MerchantCenterAccountLink.
69+
// Deletes a
70+
// [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink].
7371
// If the
7472
// [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink]
7573
// to delete does not exist, a NOT_FOUND error is returned.

‎packages/google-cloud-retail/protos/protos.json‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-retail/samples/generated/v2/snippet_metadata.google.cloud.retail.v2.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-retail",
4-
"version": "2.3.1",
4+
"version": "2.4.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-retail/samples/generated/v2alpha/snippet_metadata.google.cloud.retail.v2alpha.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-retail",
4-
"version": "2.3.1",
4+
"version": "2.4.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{
@@ -931,7 +931,7 @@
931931
"regionTag": "retail_v2alpha_generated_MerchantCenterAccountLinkService_CreateMerchantCenterAccountLink_async",
932932
"title": "CatalogService createMerchantCenterAccountLink Sample",
933933
"origin": "API_DEFINITION",
934-
"description": " Creates a MerchantCenterAccountLink. [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink] cannot be set to a different oneof field, if so an INVALID_ARGUMENT is returned.",
934+
"description": " Creates a [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink].",
935935
"canonical": true,
936936
"file": "merchant_center_account_link_service.create_merchant_center_account_link.js",
937937
"language": "JAVASCRIPT",
@@ -975,7 +975,7 @@
975975
"regionTag": "retail_v2alpha_generated_MerchantCenterAccountLinkService_DeleteMerchantCenterAccountLink_async",
976976
"title": "CatalogService deleteMerchantCenterAccountLink Sample",
977977
"origin": "API_DEFINITION",
978-
"description": " Deletes a MerchantCenterAccountLink. If the [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink] to delete does not exist, a NOT_FOUND error is returned.",
978+
"description": " Deletes a [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink]. If the [MerchantCenterAccountLink][google.cloud.retail.v2alpha.MerchantCenterAccountLink] to delete does not exist, a NOT_FOUND error is returned.",
979979
"canonical": true,
980980
"file": "merchant_center_account_link_service.delete_merchant_center_account_link.js",
981981
"language": "JAVASCRIPT",

‎packages/google-cloud-retail/samples/generated/v2beta/snippet_metadata.google.cloud.retail.v2beta.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-retail",
4-
"version": "2.3.1",
4+
"version": "2.4.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-retail/src/v2alpha/merchant_center_account_link_service_client.ts‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -514,7 +514,8 @@ export class MerchantCenterAccountLinkServiceClient {
514514
);
515515
}
516516
/**
517-
* Deletes a MerchantCenterAccountLink.
517+
* Deletes a
518+
* {@link google.cloud.retail.v2alpha.MerchantCenterAccountLink|MerchantCenterAccountLink}.
518519
* If the
519520
* {@link google.cloud.retail.v2alpha.MerchantCenterAccountLink|MerchantCenterAccountLink}
520521
* to delete does not exist, a NOT_FOUND error is returned.
@@ -620,11 +621,8 @@ export class MerchantCenterAccountLinkServiceClient {
620621
}
621622

622623
/**
623-
* Creates a MerchantCenterAccountLink.
624-
*
625-
* {@link google.cloud.retail.v2alpha.MerchantCenterAccountLink|MerchantCenterAccountLink}
626-
* cannot be set to a different oneof field, if so an INVALID_ARGUMENT is
627-
* returned.
624+
* Creates a
625+
* {@link google.cloud.retail.v2alpha.MerchantCenterAccountLink|MerchantCenterAccountLink}.
628626
*
629627
* @param {Object} request
630628
* The request object that will be sent.
@@ -732,8 +730,7 @@ export class MerchantCenterAccountLinkServiceClient {
732730
options.otherArgs.headers = options.otherArgs.headers || {};
733731
options.otherArgs.headers['x-goog-request-params'] =
734732
this._gaxModule.routingHeader.fromParams({
735-
'merchant_center_account_link.name':
736-
request.merchantCenterAccountLink!.name ?? '',
733+
parent: request.parent ?? '',
737734
});
738735
this.initialize();
739736
return this.innerApiCalls.createMerchantCenterAccountLink(

‎packages/google-cloud-retail/test/gapic_merchant_center_account_link_service_v2alpha.ts‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -564,13 +564,12 @@ describe('v2alpha.MerchantCenterAccountLinkServiceClient', () => {
564564
const request = generateSampleMessage(
565565
new protos.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest()
566566
);
567-
request.merchantCenterAccountLink ??= {};
568567
const defaultValue1 = getTypeDefaultValue(
569568
'.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest',
570-
['merchantCenterAccountLink', 'name']
569+
['parent']
571570
);
572-
request.merchantCenterAccountLink.name = defaultValue1;
573-
const expectedHeaderRequestParams = `merchant_center_account_link.name=${defaultValue1}`;
571+
request.parent = defaultValue1;
572+
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
574573
const expectedResponse = generateSampleMessage(
575574
new protos.google.longrunning.Operation()
576575
);
@@ -601,13 +600,12 @@ describe('v2alpha.MerchantCenterAccountLinkServiceClient', () => {
601600
const request = generateSampleMessage(
602601
new protos.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest()
603602
);
604-
request.merchantCenterAccountLink ??= {};
605603
const defaultValue1 = getTypeDefaultValue(
606604
'.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest',
607-
['merchantCenterAccountLink', 'name']
605+
['parent']
608606
);
609-
request.merchantCenterAccountLink.name = defaultValue1;
610-
const expectedHeaderRequestParams = `merchant_center_account_link.name=${defaultValue1}`;
607+
request.parent = defaultValue1;
608+
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
611609
const expectedResponse = generateSampleMessage(
612610
new protos.google.longrunning.Operation()
613611
);
@@ -659,13 +657,12 @@ describe('v2alpha.MerchantCenterAccountLinkServiceClient', () => {
659657
const request = generateSampleMessage(
660658
new protos.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest()
661659
);
662-
request.merchantCenterAccountLink ??= {};
663660
const defaultValue1 = getTypeDefaultValue(
664661
'.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest',
665-
['merchantCenterAccountLink', 'name']
662+
['parent']
666663
);
667-
request.merchantCenterAccountLink.name = defaultValue1;
668-
const expectedHeaderRequestParams = `merchant_center_account_link.name=${defaultValue1}`;
664+
request.parent = defaultValue1;
665+
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
669666
const expectedError = new Error('expected');
670667
client.innerApiCalls.createMerchantCenterAccountLink =
671668
stubLongRunningCall(undefined, expectedError);
@@ -695,13 +692,12 @@ describe('v2alpha.MerchantCenterAccountLinkServiceClient', () => {
695692
const request = generateSampleMessage(
696693
new protos.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest()
697694
);
698-
request.merchantCenterAccountLink ??= {};
699695
const defaultValue1 = getTypeDefaultValue(
700696
'.google.cloud.retail.v2alpha.CreateMerchantCenterAccountLinkRequest',
701-
['merchantCenterAccountLink', 'name']
697+
['parent']
702698
);
703-
request.merchantCenterAccountLink.name = defaultValue1;
704-
const expectedHeaderRequestParams = `merchant_center_account_link.name=${defaultValue1}`;
699+
request.parent = defaultValue1;
700+
const expectedHeaderRequestParams = `parent=${defaultValue1}`;
705701
const expectedError = new Error('expected');
706702
client.innerApiCalls.createMerchantCenterAccountLink =
707703
stubLongRunningCall(undefined, undefined, expectedError);

0 commit comments

Comments
 (0)