datastore: return base64 string for a nextQuery startVal

mcfarljw · stephenplusplus · commit a80ff9b0b98d · 2016-04-07T08:10:54.000-04:00
diff --git a/lib/datastore/request.js b/lib/datastore/request.js
@@ -465,7 +465,7 @@ DatastoreRequest.prototype.runQuery = function(query, callback) {
       var offset = query.offsetVal === -1 ? 0 : query.offsetVal;
       var nextOffset = offset - resp.batch.skippedResults;
       nextQuery = extend(true, new Query(), query);
-      nextQuery.start(endCursor).offset(nextOffset);
+      nextQuery.start(endCursor.toString('base64')).offset(nextOffset);
     }
 
     if (notFinished) {
diff --git a/test/datastore/request.js b/test/datastore/request.js
@@ -542,7 +542,7 @@ describe('Request', function() {
 
     describe('success', function() {
       var entityResults = ['a', 'b', 'c'];
-      var endCursor = 'endCursor';
+      var endCursor = new Buffer('abc');
 
       var apiResponse = {
         batch: {
@@ -623,7 +623,7 @@ describe('Request', function() {
 
         FakeQuery.prototype.start = function(endCursor_) {
           nextQuery = this;
-          assert.strictEqual(endCursor_, endCursor);
+          assert.strictEqual(endCursor_, endCursor.toString('base64'));
           startCalled = true;
           return this;
         };
@@ -677,7 +677,7 @@ describe('Request', function() {
         var offsetCalled = false;
 
         FakeQuery.prototype.start = function(endCursor_) {
-          assert.strictEqual(endCursor_, endCursor);
+          assert.strictEqual(endCursor_, endCursor.toString('base64'));
           startCalled = true;
           return this;
         };

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ DatastoreRequest.prototype.runQuery = function(query, callback) {`
`465`	`465`	`var offset = query.offsetVal === -1 ? 0 : query.offsetVal;`
`466`	`466`	`var nextOffset = offset - resp.batch.skippedResults;`
`467`	`467`	`nextQuery = extend(true, new Query(), query);`
`468`		`- nextQuery.start(endCursor).offset(nextOffset);`
	`468`	`+ nextQuery.start(endCursor.toString('base64')).offset(nextOffset);`
`469`	`469`	`}`
`470`	`470`
`471`	`471`	`if (notFinished) {`