Skip to content

Commit 9383ba4

Browse files
common (grpc): use correct nullValue value
1 parent 339cda2 commit 9383ba4

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

lib/common/grpc-service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ GrpcService.convertValue_ = function(value) {
310310

311311
if (is.null(value)) {
312312
convertedValue = {
313-
nullValue: null
313+
nullValue: 0
314314
};
315315
} else if (is.number(value)) {
316316
convertedValue = {

system-test/logging.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,9 @@ describe('Logging', function() {
243243
// object data
244244
log.entry({ delegate: 'my_username' }),
245245

246+
// null data
247+
log.entry({ nonValue: null }),
248+
246249
// nested object data
247250
log.entry({
248251
nested: {

test/common/grpc-service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,7 +680,7 @@ describe('GrpcService', function() {
680680
var buffer = new Buffer('Value');
681681

682682
assert.deepEqual(GrpcService.convertValue_(null), {
683-
nullValue: null
683+
nullValue: 0
684684
});
685685

686686
assert.deepEqual(GrpcService.convertValue_(1), {

0 commit comments

Comments
 (0)