Skip to content

Commit 8b0f5eb

Browse files
feywindgcf-owl-bot[bot]
feywind
and
gcf-owl-bot[bot]
authored
chore!: migrate to Node 18 (#2024)
* chore!: migrate to Node 18 * chore: linter fix pass * chore: remove accidentally added file * samples: fix linting and typelessing of samples * build: remove typeless bot stuff from owlbot.py * feat: fix a bunch of linter errors, and import new gapic classes * fix: revert some of the promise fixes * tests: fix various test issues caused by version upgrades * chore: linter fixes * chore: try to bypass linting on TS samples for now * build: try updating lint and samples scripts * build: two owlbot related updates * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: revert execa to dodge esm for now * chore: also revert execa import for older version * chore: update execa reference once more * chore!: remove legacy otel support * feat!: remove legacy ack deadline parameters, and move maxExtension into subscriber options * build: further revert execa's version * build: more execa adjustments * feat: time to say goodbye to some more old OTel cruft * tests: this will be the day ... that tsc starts paying attention to @internal, apparently * chore: revert package.json version changes so release-please can do it * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent a331e90 commit 8b0f5eb

106 files changed

Lines changed: 277 additions & 279 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎handwritten/pubsub/samples/commitAvroSchema.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async function commitAvroSchema(schemaNameOrId, avscFile) {
6969

7070
function main(
7171
schemaNameOrId = 'YOUR_SCHEMA_NAME_OR_ID',
72-
avscFile = 'path/to/an/avro/schema/file/(.avsc)/formatted/in/json'
72+
avscFile = 'path/to/an/avro/schema/file/(.avsc)/formatted/in/json',
7373
) {
7474
commitAvroSchema(schemaNameOrId, avscFile).catch(err => {
7575
console.error(err.message);

‎handwritten/pubsub/samples/commitProtoSchema.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async function commitProtoSchema(schemaNameOrId, protoFile) {
6969

7070
function main(
7171
schemaNameOrId = 'YOUR_SCHEMA_NAME_OR_ID',
72-
protoFile = 'path/to/a/proto/schema/file/(.proto)/formatted/in/protcol/buffers'
72+
protoFile = 'path/to/a/proto/schema/file/(.proto)/formatted/in/protcol/buffers',
7373
) {
7474
commitProtoSchema(schemaNameOrId, protoFile).catch(err => {
7575
console.error(err.message);

‎handwritten/pubsub/samples/createAvroSchema.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async function createAvroSchema(schemaNameOrId, avscFile) {
4949
const schema = await pubSubClient.createSchema(
5050
schemaNameOrId,
5151
SchemaTypes.Avro,
52-
definition
52+
definition,
5353
);
5454

5555
const name = await schema.getName();
@@ -59,7 +59,7 @@ async function createAvroSchema(schemaNameOrId, avscFile) {
5959

6060
function main(
6161
schemaNameOrId = 'YOUR_SCHEMA_NAME_OR_ID',
62-
avscFile = 'path/to/an/avro/schema/file/(.avsc)/formatted/in/json'
62+
avscFile = 'path/to/an/avro/schema/file/(.avsc)/formatted/in/json',
6363
) {
6464
createAvroSchema(schemaNameOrId, avscFile).catch(err => {
6565
console.error(err.message);

‎handwritten/pubsub/samples/createBigQuerySubscription.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const pubSubClient = new PubSub();
4646
async function createBigQuerySubscription(
4747
topicNameOrId,
4848
subscriptionNameOrId,
49-
bigqueryTableId
49+
bigqueryTableId,
5050
) {
5151
const options = {
5252
bigqueryConfig: {
@@ -66,12 +66,12 @@ async function createBigQuerySubscription(
6666
function main(
6767
topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
6868
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
69-
bigqueryTableId = 'YOUR_TABLE_ID'
69+
bigqueryTableId = 'YOUR_TABLE_ID',
7070
) {
7171
createBigQuerySubscription(
7272
topicNameOrId,
7373
subscriptionNameOrId,
74-
bigqueryTableId
74+
bigqueryTableId,
7575
).catch(err => {
7676
console.error(err.message);
7777
process.exitCode = 1;

‎handwritten/pubsub/samples/createProtoSchema.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async function createProtoSchema(schemaNameOrId, protoFile) {
4949
const schema = await pubSubClient.createSchema(
5050
schemaNameOrId,
5151
SchemaTypes.ProtocolBuffer,
52-
definition
52+
definition,
5353
);
5454

5555
const fullName = await schema.getName();
@@ -59,7 +59,7 @@ async function createProtoSchema(schemaNameOrId, protoFile) {
5959

6060
function main(
6161
schemaNameOrId = 'YOUR_SCHEMA_NAME_OR_ID',
62-
protoFile = 'path/to/a/proto/schema/file/(.proto)/formatted/in/protcol/buffers'
62+
protoFile = 'path/to/a/proto/schema/file/(.proto)/formatted/in/protcol/buffers',
6363
) {
6464
createProtoSchema(schemaNameOrId, protoFile).catch(err => {
6565
console.error(err.message);

‎handwritten/pubsub/samples/createPushSubscription.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const pubSubClient = new PubSub();
4646
async function createPushSubscription(
4747
pushEndpoint,
4848
topicNameOrId,
49-
subscriptionNameOrId
49+
subscriptionNameOrId,
5050
) {
5151
const options = {
5252
pushConfig: {
@@ -66,12 +66,12 @@ async function createPushSubscription(
6666
function main(
6767
pushEndpoint = 'YOUR_ENDPOINT_URL',
6868
topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
69-
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID'
69+
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
7070
) {
7171
createPushSubscription(
7272
pushEndpoint,
7373
topicNameOrId,
74-
subscriptionNameOrId
74+
subscriptionNameOrId,
7575
).catch(err => {
7676
console.error(err.message);
7777
process.exitCode = 1;

‎handwritten/pubsub/samples/createPushSubscriptionNoWrapper.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const pubSubClient = new PubSub();
4646
async function createPushSubscriptionNoWrapper(
4747
pushEndpoint,
4848
topicNameOrId,
49-
subscriptionNameOrId
49+
subscriptionNameOrId,
5050
) {
5151
const options = {
5252
pushConfig: {
@@ -72,12 +72,12 @@ async function createPushSubscriptionNoWrapper(
7272
function main(
7373
pushEndpoint = 'YOUR_ENDPOINT_URL',
7474
topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
75-
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID'
75+
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
7676
) {
7777
createPushSubscriptionNoWrapper(
7878
pushEndpoint,
7979
topicNameOrId,
80-
subscriptionNameOrId
80+
subscriptionNameOrId,
8181
).catch(err => {
8282
console.error(err.message);
8383
process.exitCode = 1;

‎handwritten/pubsub/samples/createSubscription.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ async function createSubscription(topicNameOrId, subscriptionNameOrId) {
5353

5454
function main(
5555
topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
56-
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID'
56+
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
5757
) {
5858
createSubscription(topicNameOrId, subscriptionNameOrId).catch(err => {
5959
console.error(err.message);

‎handwritten/pubsub/samples/createSubscriptionWithCloudStorage.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ async function createCloudStorageSubscription(
5252
bucket,
5353
filenamePrefix,
5454
filenameSuffix,
55-
maxDuration
55+
maxDuration,
5656
) {
5757
const options = {
5858
cloudStorageConfig: {
@@ -70,7 +70,7 @@ async function createCloudStorageSubscription(
7070
.createSubscription(subscriptionName, options);
7171

7272
console.log(
73-
`Created subscription ${subscriptionName} with a cloud storage configuration.`
73+
`Created subscription ${subscriptionName} with a cloud storage configuration.`,
7474
);
7575
}
7676
// [END pubsub_create_cloud_storage_subscription]
@@ -81,15 +81,15 @@ function main(
8181
bucket = 'YOUR_BUCKET_NAME',
8282
filenamePrefix = 'YOUR_FILENAME_PREFIX',
8383
filenameSuffix = 'YOUR_FILENAME_SUFFIX',
84-
maxDuration = 60
84+
maxDuration = 60,
8585
) {
8686
createCloudStorageSubscription(
8787
topicName,
8888
subscriptionName,
8989
bucket,
9090
filenamePrefix,
9191
filenameSuffix,
92-
maxDuration
92+
maxDuration,
9393
).catch(err => {
9494
console.error(err.message);
9595
process.exitCode = 1;

‎handwritten/pubsub/samples/createSubscriptionWithDeadLetterPolicy.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const pubSubClient = new PubSub();
4646
async function createSubscriptionWithDeadLetterPolicy(
4747
topicNameOrId,
4848
subscriptionNameOrId,
49-
deadLetterTopicNameOrId
49+
deadLetterTopicNameOrId,
5050
) {
5151
// Creates a new subscription
5252
const options = {
@@ -59,23 +59,23 @@ async function createSubscriptionWithDeadLetterPolicy(
5959
.topic(topicNameOrId)
6060
.createSubscription(subscriptionNameOrId, options);
6161
console.log(
62-
`Created subscription ${subscriptionNameOrId} with dead letter topic ${deadLetterTopicNameOrId}.`
62+
`Created subscription ${subscriptionNameOrId} with dead letter topic ${deadLetterTopicNameOrId}.`,
6363
);
6464
console.log(
65-
'To process dead letter messages, remember to add a subscription to your dead letter topic.'
65+
'To process dead letter messages, remember to add a subscription to your dead letter topic.',
6666
);
6767
}
6868
// [END pubsub_dead_letter_create_subscription]
6969

7070
function main(
7171
topicNameOrId = 'YOUR_TOPIC_NAME_OR_ID',
7272
subscriptionNameOrId = 'YOUR_SUBSCRIPTION_NAME_OR_ID',
73-
deadLetterTopicNameOrId = 'YOUR_DEAD_LETTER_TOPIC_NAME_OR_ID'
73+
deadLetterTopicNameOrId = 'YOUR_DEAD_LETTER_TOPIC_NAME_OR_ID',
7474
) {
7575
createSubscriptionWithDeadLetterPolicy(
7676
topicNameOrId,
7777
subscriptionNameOrId,
78-
deadLetterTopicNameOrId
78+
deadLetterTopicNameOrId,
7979
).catch(err => {
8080
console.error(err.message);
8181
process.exitCode = 1;

0 commit comments

Comments
 (0)