Improve coverage in common. (#2156)

lukesneeringer · web-flow · commit 895529e11318 · 2017-03-29T13:25:12.000-07:00
diff --git a/packages/common/src/util.js b/packages/common/src/util.js
@@ -123,7 +123,7 @@ util.PartialFailureError = createErrorClass('PartialFailureError', function(b) {
  * @param {function} callback - The callback function.
  */
 function handleResp(err, resp, body, callback) {
-  callback = callback || noop;
+  callback = callback || util.noop;
 
   var parsedResp = extend(
     true,
@@ -217,8 +217,7 @@ util.parseHttpRespBody = parseHttpRespBody;
  *     stream has completed.
  */
 function makeWritableStream(dup, options, onComplete) {
-  onComplete = onComplete || noop;
-  options = options || {};
+  onComplete = onComplete || util.noop;
 
   var writeStream = through();
   dup.setWritable(writeStream);
diff --git a/packages/common/test/service-object.js b/packages/common/test/service-object.js
@@ -363,6 +363,13 @@ describe('ServiceObject', function() {
       serviceObject.get(assert.ifError);
     });
 
+    it('handles not getting a config', function(done) {
+      serviceObject.getMetadata = function() {
+        done();
+      };
+      serviceObject.get(undefined, assert.ifError);
+    });
+
     it('should execute callback with error & metadata', function(done) {
       var error = new Error('Error.');
       var metadata = {};
diff --git a/packages/common/test/util.js b/packages/common/test/util.js
@@ -338,6 +338,10 @@ describe('common/util', function() {
       });
     });
 
+    it('uses a no-op callback if none is sent', function() {
+      util.handleResp(undefined, {}, '');
+    });
+
     it('should parse response', function(done) {
       var err = { a: 'b', c: 'd' };
       var resp = { a: 'b', c: 'd' };
@@ -1759,6 +1763,18 @@ describe('common/util', function() {
           done();
         });
       });
+
+      it('should not mistake non-function args for callbacks', function(done) {
+        var func = util.promisify(function(foo, optional) {
+          assert.strictEqual(arguments.length, 2);
+          assert(is.fn(optional));
+          optional(null);
+        });
+
+        func('foo').then(function() {
+          done();
+        });
+      });
     });
   });
 });
