Skip to content

Commit 8286972

Browse files
cristiancavallicristiancavalli
committed
Remove Uncaught Exception Handler
- Remove the uncaught exception handler - Remove the corresponding tests & documentation - Add new documentation to README stating how feature can be in application code
1 parent fe6a11f commit 8286972

6 files changed

Lines changed: 0 additions & 315 deletions

File tree

‎packages/error-reporting/src/configuration.js‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,6 @@ var Configuration = function(givenConfig, logger) {
5757
* @defaultvalue Object
5858
*/
5959
this._logger = logger;
60-
/**
61-
* The _reportUncaughtExceptions property is meant to contain the optional
62-
* runtime configuration property reportUncaughtExceptions. This property will
63-
* default to true if not given false through the runtime configuration
64-
* meaning that the default behavior is to catch uncaught exceptions, report
65-
* them to the Stackdriver Errors API and then exit. If given false uncaught
66-
* exceptions will not be listened for and not be caught or reported.
67-
* @memberof Configuration
68-
* @private
69-
* @type {Boolean}
70-
* @defaultvalue true
71-
*/
72-
this._reportUncaughtExceptions = true;
7360
/**
7461
* The _shouldReportErrorsToAPI property is meant to denote whether or not
7562
* the Stackdriver error reporting library will actually try to report Errors
@@ -276,12 +263,6 @@ Configuration.prototype._gatherLocalConfiguration = function() {
276263
'true in the runtime configuration object'
277264
].join(' '));
278265
}
279-
if (isBoolean(this._givenConfiguration.reportUncaughtExceptions)) {
280-
this._reportUncaughtExceptions = this._givenConfiguration
281-
.reportUncaughtExceptions;
282-
} else if (has(this._givenConfiguration, 'reportUncaughtExceptions')) {
283-
throw new Error('config.reportUncaughtExceptions must be a boolean');
284-
}
285266
if (isString(this._givenConfiguration.key)) {
286267
this._key = this._givenConfiguration.key;
287268
} else if (has(this._givenConfiguration, 'key')) {
@@ -357,16 +338,6 @@ Configuration.prototype._checkLocalProjectId = function(cb) {
357338
}
358339
return this._projectId;
359340
};
360-
/**
361-
* Returns the _reportUncaughtExceptions property on the instance.
362-
* @memberof Configuration
363-
* @public
364-
* @function getReportUncaughtExceptions
365-
* @returns {Boolean} - returns the _reportUncaughtExceptions property
366-
*/
367-
Configuration.prototype.getReportUncaughtExceptions = function() {
368-
return this._reportUncaughtExceptions;
369-
};
370341
/**
371342
* Returns the _shouldReportErrorsToAPI property on the instance.
372343
* @memberof Configuration

‎packages/error-reporting/src/index.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ var manual = require('./interfaces/manual.js');
2525
var express = require('./interfaces/express.js');
2626
var restify = require('./interfaces/restify');
2727
var messageBuilder = require('./interfaces/message-builder.js');
28-
var uncaughtException = require('./interfaces/uncaught.js');
2928
var createLogger = require('./logger.js');
3029

3130
/**
@@ -84,9 +83,6 @@ function Errors(initConfiguration) {
8483
var config = new Configuration(initConfiguration, logger);
8584
var client = new AuthClient(config, logger);
8685

87-
// Setup the uncaught exception handler
88-
uncaughtException(client, config);
89-
9086
// Build the application interfaces for use by the hosting application
9187
/**
9288
* @example

‎packages/error-reporting/src/interfaces/uncaught.js‎

Lines changed: 0 additions & 67 deletions
This file was deleted.

‎packages/error-reporting/test/fixtures/uncaughtExitBehaviour.js‎

Lines changed: 0 additions & 93 deletions
This file was deleted.

‎packages/error-reporting/test/unit/testConfiguration.js‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ var nock = require('nock');
2929

3030
var METADATA_URL = 'http://metadata.google.internal/computeMetadata/v1/project';
3131

32-
process.removeAllListeners('uncaughtException');
3332
var env = {
3433
NODE_ENV: process.env.NODE_ENV,
3534
GCLOUD_PROJECT: process.env.GCLOUD_PROJECT,
@@ -84,12 +83,6 @@ describe('Configuration class', function() {
8483
it('Should have a property reflecting the config argument', function() {
8584
assert.deepEqual(c._givenConfiguration, stubConfig);
8685
});
87-
it('Should reportUncaughtExceptions', function() {
88-
assert.strictEqual(c.getReportUncaughtExceptions(), true);
89-
});
90-
it('Should not reportUncaughtExceptions', function() {
91-
assert.strictEqual(c.getShouldReportErrorsToAPI(), false);
92-
});
9386
it('Should not have a project id', function() {
9487
assert.strictEqual(c._projectId, null);
9588
});
@@ -125,11 +118,6 @@ describe('Configuration class', function() {
125118
});
126119
});
127120
describe('exception behaviour', function() {
128-
it('Should throw', function() {
129-
assert.throws(function() {
130-
new Configuration({reportUncaughtExceptions: 1}, logger);
131-
});
132-
});
133121
it('Should throw if invalid type for key', function() {
134122
assert.throws(function() {
135123
new Configuration({key: null}, logger);
@@ -294,21 +282,6 @@ describe('Configuration class', function() {
294282
assert.strictEqual(c.getKey(), key);
295283
});
296284
});
297-
describe('reportUncaughtExceptions', function() {
298-
var c;
299-
var projectId = '123-xyz';
300-
var reportUncaughtExceptions = false;
301-
before(function() {
302-
c = new Configuration({
303-
projectId: projectId,
304-
reportUncaughtExceptions: reportUncaughtExceptions
305-
});
306-
});
307-
it('Should assign', function() {
308-
assert.strictEqual(c.getReportUncaughtExceptions(),
309-
reportUncaughtExceptions);
310-
});
311-
});
312285
});
313286
});
314287
});

‎packages/error-reporting/test/unit/testUncaught.js‎

Lines changed: 0 additions & 95 deletions
This file was deleted.

0 commit comments

Comments
 (0)