Skip to content

Commit 8073ac0

Browse files
gcf-owl-bot[bot]alexander-fenster
gcf-owl-bot[bot]
and
alexander-fenster
authored
fix: [asset] Change retry configuration for API calls (#4144)
* feat: Add client library support for AssetService v1 AnalyzeOrgPolicies API feat: Add client library support for AssetService v1 AnalyzeOrgPolicyGovernedContainers API feat: Add client library support for AssetService v1 AnalyzeOrgPolicyGovernedAssets API PiperOrigin-RevId: 520696122 Source-Link: googleapis/googleapis@fb446a2 Source-Link: googleapis/googleapis-gen@f4b9936 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFzc2V0Ly5Pd2xCb3QueWFtbCIsImgiOiJmNGI5OTM2NDAzZmFmODQ3MTgwYTM1MzYzNmJlNTE1ZDIxZDVjYWM0In0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alexander Fenster <[email protected]>
1 parent 5abd1c3 commit 8073ac0

7 files changed

Lines changed: 38 additions & 35 deletions

File tree

‎packages/google-cloud-asset/protos/google/cloud/asset/v1/asset_service.proto‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 Google LLC
1+
// Copyright 2023 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -563,7 +563,7 @@ message CreateFeedRequest {
563563
// Required. The name of the project/folder/organization where this feed
564564
// should be created in. It can only be an organization number (such as
565565
// "organizations/123"), a folder number (such as "folders/123"), a project ID
566-
// (such as "projects/my-project-id")", or a project number (such as
566+
// (such as "projects/my-project-id"), or a project number (such as
567567
// "projects/12345").
568568
string parent = 1 [(google.api.field_behavior) = REQUIRED];
569569

@@ -1621,8 +1621,8 @@ message CreateSavedQueryRequest {
16211621
// Required. The name of the project/folder/organization where this
16221622
// saved_query should be created in. It can only be an organization number
16231623
// (such as "organizations/123"), a folder number (such as "folders/123"), a
1624-
// project ID (such as "projects/my-project-id")", or a project number (such
1625-
// as "projects/12345").
1624+
// project ID (such as "projects/my-project-id"), or a project number (such as
1625+
// "projects/12345").
16261626
string parent = 1 [
16271627
(google.api.field_behavior) = REQUIRED,
16281628
(google.api.resource_reference) = {
@@ -1684,8 +1684,8 @@ message ListSavedQueriesRequest {
16841684

16851685
// Optional. The maximum number of saved queries to return per page. The
16861686
// service may return fewer than this value. If unspecified, at most 50 will
1687-
// be returned.
1688-
// The maximum value is 1000; values above 1000 will be coerced to 1000.
1687+
// be returned. The maximum value is 1000; values above 1000 will be coerced
1688+
// to 1000.
16891689
int32 page_size = 2 [(google.api.field_behavior) = OPTIONAL];
16901690

16911691
// Optional. A page token, received from a previous `ListSavedQueries` call.
@@ -2523,19 +2523,19 @@ message AnalyzeOrgPolicyGovernedAssetsResponse {
25232523
// [AnalyzeOrgPolicyGovernedAssetsResponse.GovernedResource.full_resource_name][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedAssetsResponse.GovernedResource.full_resource_name].
25242524
string parent = 2;
25252525

2526-
// The project that this resource belongs to, in the form of
2526+
// The project that this resource belongs to, in the format of
25272527
// projects/{PROJECT_NUMBER}. This field is available when the resource
25282528
// belongs to a project.
25292529
string project = 5;
25302530

2531-
// The folder(s) that this resource belongs to, in the form of
2531+
// The folder(s) that this resource belongs to, in the format of
25322532
// folders/{FOLDER_NUMBER}. This field is available when the resource
2533-
// belongs(directly or cascadingly) to one or more folders.
2533+
// belongs (directly or cascadingly) to one or more folders.
25342534
repeated string folders = 6;
25352535

2536-
// The organization that this resource belongs to, in the form of
2536+
// The organization that this resource belongs to, in the format of
25372537
// organizations/{ORGANIZATION_NUMBER}. This field is available when the
2538-
// resource belongs(directly or cascadingly) to an organization.
2538+
// resource belongs (directly or cascadingly) to an organization.
25392539
string organization = 7;
25402540
}
25412541

@@ -2553,19 +2553,19 @@ message AnalyzeOrgPolicyGovernedAssetsResponse {
25532553
// The IAM policy directly set on the given resource.
25542554
google.iam.v1.Policy policy = 2;
25552555

2556-
// The project that this IAM policy belongs to, in the form of
2556+
// The project that this IAM policy belongs to, in the format of
25572557
// projects/{PROJECT_NUMBER}. This field is available when the IAM policy
25582558
// belongs to a project.
25592559
string project = 5;
25602560

2561-
// The folder(s) that this IAM policy belongs to, in the form of
2561+
// The folder(s) that this IAM policy belongs to, in the format of
25622562
// folders/{FOLDER_NUMBER}. This field is available when the IAM policy
2563-
// belongs(directly or cascadingly) to one or more folders.
2563+
// belongs (directly or cascadingly) to one or more folders.
25642564
repeated string folders = 6;
25652565

2566-
// The organization that this IAM policy belongs to, in the form of
2566+
// The organization that this IAM policy belongs to, in the format of
25672567
// organizations/{ORGANIZATION_NUMBER}. This field is available when the
2568-
// IAM policy belongs(directly or cascadingly) to an organization.
2568+
// IAM policy belongs (directly or cascadingly) to an organization.
25692569
string organization = 7;
25702570
}
25712571

‎packages/google-cloud-asset/protos/google/cloud/asset/v1/assets.proto‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 Google LLC
1+
// Copyright 2023 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -307,7 +307,7 @@ message RelatedAsset {
307307
}
308308

309309
// A result of Resource Search, containing information of a cloud resource.
310-
// Next ID: 31
310+
// Next ID: 32
311311
message ResourceSearchResult {
312312
// The full resource name of this resource. Example:
313313
// `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.

‎packages/google-cloud-asset/samples/generated/v1/asset_service.create_feed.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function main(parent, feedId, feed) {
3232
* Required. The name of the project/folder/organization where this feed
3333
* should be created in. It can only be an organization number (such as
3434
* "organizations/123"), a folder number (such as "folders/123"), a project ID
35-
* (such as "projects/my-project-id")", or a project number (such as
35+
* (such as "projects/my-project-id"), or a project number (such as
3636
* "projects/12345").
3737
*/
3838
// const parent = 'abc123'

‎packages/google-cloud-asset/samples/generated/v1/asset_service.create_saved_query.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ function main(parent, savedQuery, savedQueryId) {
3232
* Required. The name of the project/folder/organization where this
3333
* saved_query should be created in. It can only be an organization number
3434
* (such as "organizations/123"), a folder number (such as "folders/123"), a
35-
* project ID (such as "projects/my-project-id")", or a project number (such
36-
* as "projects/12345").
35+
* project ID (such as "projects/my-project-id"), or a project number (such as
36+
* "projects/12345").
3737
*/
3838
// const parent = 'abc123'
3939
/**

‎packages/google-cloud-asset/samples/generated/v1/asset_service.list_saved_queries.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ function main(parent) {
4646
/**
4747
* Optional. The maximum number of saved queries to return per page. The
4848
* service may return fewer than this value. If unspecified, at most 50 will
49-
* be returned.
50-
* The maximum value is 1000; values above 1000 will be coerced to 1000.
49+
* be returned. The maximum value is 1000; values above 1000 will be coerced
50+
* to 1000.
5151
*/
5252
// const pageSize = 1234
5353
/**

‎packages/google-cloud-asset/src/v1/asset_service_client.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ export class AssetServiceClient {
610610
* Required. The name of the project/folder/organization where this feed
611611
* should be created in. It can only be an organization number (such as
612612
* "organizations/123"), a folder number (such as "folders/123"), a project ID
613-
* (such as "projects/my-project-id")", or a project number (such as
613+
* (such as "projects/my-project-id"), or a project number (such as
614614
* "projects/12345").
615615
* @param {string} request.feedId
616616
* Required. This is the client-assigned asset feed identifier and it needs to
@@ -1417,8 +1417,8 @@ export class AssetServiceClient {
14171417
* Required. The name of the project/folder/organization where this
14181418
* saved_query should be created in. It can only be an organization number
14191419
* (such as "organizations/123"), a folder number (such as "folders/123"), a
1420-
* project ID (such as "projects/my-project-id")", or a project number (such
1421-
* as "projects/12345").
1420+
* project ID (such as "projects/my-project-id"), or a project number (such as
1421+
* "projects/12345").
14221422
* @param {google.cloud.asset.v1.SavedQuery} request.savedQuery
14231423
* Required. The saved_query details. The `name` field must be empty as it
14241424
* will be generated based on the parent and saved_query_id.
@@ -3703,8 +3703,8 @@ export class AssetServiceClient {
37033703
* @param {number} [request.pageSize]
37043704
* Optional. The maximum number of saved queries to return per page. The
37053705
* service may return fewer than this value. If unspecified, at most 50 will
3706-
* be returned.
3707-
* The maximum value is 1000; values above 1000 will be coerced to 1000.
3706+
* be returned. The maximum value is 1000; values above 1000 will be coerced
3707+
* to 1000.
37083708
* @param {string} [request.pageToken]
37093709
* Optional. A page token, received from a previous `ListSavedQueries` call.
37103710
* Provide this to retrieve the subsequent page.
@@ -3812,8 +3812,8 @@ export class AssetServiceClient {
38123812
* @param {number} [request.pageSize]
38133813
* Optional. The maximum number of saved queries to return per page. The
38143814
* service may return fewer than this value. If unspecified, at most 50 will
3815-
* be returned.
3816-
* The maximum value is 1000; values above 1000 will be coerced to 1000.
3815+
* be returned. The maximum value is 1000; values above 1000 will be coerced
3816+
* to 1000.
38173817
* @param {string} [request.pageToken]
38183818
* Optional. A page token, received from a previous `ListSavedQueries` call.
38193819
* Provide this to retrieve the subsequent page.
@@ -3875,8 +3875,8 @@ export class AssetServiceClient {
38753875
* @param {number} [request.pageSize]
38763876
* Optional. The maximum number of saved queries to return per page. The
38773877
* service may return fewer than this value. If unspecified, at most 50 will
3878-
* be returned.
3879-
* The maximum value is 1000; values above 1000 will be coerced to 1000.
3878+
* be returned. The maximum value is 1000; values above 1000 will be coerced
3879+
* to 1000.
38803880
* @param {string} [request.pageToken]
38813881
* Optional. A page token, received from a previous `ListSavedQueries` call.
38823882
* Provide this to retrieve the subsequent page.

‎packages/google-cloud-asset/src/v1/asset_service_client_config.json‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,15 +123,18 @@
123123
"retry_params_name": "default"
124124
},
125125
"AnalyzeOrgPolicies": {
126-
"retry_codes_name": "non_idempotent",
126+
"timeout_millis": 60000,
127+
"retry_codes_name": "idempotent",
127128
"retry_params_name": "default"
128129
},
129130
"AnalyzeOrgPolicyGovernedContainers": {
130-
"retry_codes_name": "non_idempotent",
131+
"timeout_millis": 60000,
132+
"retry_codes_name": "idempotent",
131133
"retry_params_name": "default"
132134
},
133135
"AnalyzeOrgPolicyGovernedAssets": {
134-
"retry_codes_name": "non_idempotent",
136+
"timeout_millis": 60000,
137+
"retry_codes_name": "idempotent",
135138
"retry_params_name": "default"
136139
}
137140
}

0 commit comments

Comments
 (0)