test coverage

stephenplusplus · stephenplusplus · commit 7e2b679bb628 · 2016-11-17T10:28:25.000-05:00
diff --git a/packages/pubsub/src/index.js b/packages/pubsub/src/index.js
@@ -486,6 +486,7 @@ PubSub.prototype.subscribe = function(topic, subName, options, callback) {
   }
 
   if (is.object(subName)) {
+    callback = options;
     options = subName;
     subName = '';
   }
diff --git a/packages/pubsub/test/index.js b/packages/pubsub/test/index.js
@@ -499,6 +499,16 @@ describe('PubSub', function() {
       pubsub.subscribe(TOPIC_NAME, done);
     });
 
+    it('should not require a sub name and accept options', function(done) {
+      var opts = {};
+
+      pubsub.request = function(protoOpts, reqOpts, callback) {
+        callback(null, apiResponse);
+      };
+
+      pubsub.subscribe(TOPIC_NAME, opts, done);
+    });
+
     it('should not require configuration options', function(done) {
       pubsub.request = function(protoOpts, reqOpts, callback) {
         callback(null, apiResponse);
@@ -724,6 +734,18 @@ describe('PubSub', function() {
       pubsub.subscription();
     });
 
+    it('should not require a name and accept options', function(done) {
+      SubscriptionOverride = function(pubsub, options) {
+        var expectedOptions = extend({}, CONFIG);
+        expectedOptions.name = undefined;
+
+        assert.deepEqual(options, expectedOptions);
+        done();
+      };
+
+      pubsub.subscription(CONFIG);
+    });
+
     it('should not require options', function(done) {
       SubscriptionOverride = function(pubsub, options) {
         assert.deepEqual(options, {

Original file line number	Diff line number	Diff line change
`@@ -486,6 +486,7 @@ PubSub.prototype.subscribe = function(topic, subName, options, callback) {`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`if (is.object(subName)) {`
	`489`	`+ callback = options;`
`489`	`490`	`options = subName;`
`490`	`491`	`subName = '';`
`491`	`492`	`}`