Changed test "query success should return the outputValue as the winner" to match the expected prediction#output response returned by Trainedmodels: predict for Regression models. prediction#output response for Regression models does not contain an outputMulti response

savethefails · stephenplusplus · commit 63f658619e88 · 2016-03-14T11:56:39.000-04:00
Removed 'scores' from returned results of prediction/model#query when returning a `prediction#output` response from Trainedmodels:predict for Regression models. Trainedmodels:predict response for Regression models does not contain `outputMulti` so no scores should be calculated. Added name to authors/contributors as per [contributing guidelines](https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/CONTRIBUTING.md)
diff --git a/AUTHORS b/AUTHORS
@@ -8,3 +8,4 @@
 
 Google Inc.
 Anand Suresh
+Brett Bergmann
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
@@ -11,11 +11,12 @@
 
 # Keep the list alphabetically sorted.
 
+Anand Suresh <anandsuresh@gmail.com>
+Brett Bergmann <me@brettbergmann.com>
 Burcu Dogan <jbd@google.com>
+Hector Rovira <hrovira@gmail.com>
 Johan Euphrosine <proppy@google.com>
 Marco Ziccardi <marco.ziccard@gmail.com>
 Patrick Costello <pcostell@google.com>
 Silvano Luciani <silvano@google.com>
 Stephen Sawchuk <sawchuk@gmail.com>
-Anand Suresh <anandsuresh@gmail.com>
-Hector Rovira <hrovira@gmail.com>
diff --git a/lib/prediction/model.js b/lib/prediction/model.js
@@ -347,15 +347,18 @@ Model.prototype.query = function(input, callback) {
 
     var results = {
       winner: resp.outputLabel || resp.outputValue,
-      scores: resp.outputMulti
+    };
+
+    if (resp.outputMulti) {
+      results.scores = resp.outputMulti
         .sort(function(a, b) {
           return a.score < b.score ? 1 : a.score > b.score ? -1 : 0;
         })
         .map(function(scoreObject) {
           scoreObject.score = parseFloat(scoreObject.score);
           return scoreObject;
-        })
-    };
+        });
+    }
 
     callback(null, results, resp);
   });
diff --git a/test/prediction/model.js b/test/prediction/model.js
@@ -459,6 +459,7 @@ describe('Index', function() {
         });
 
         delete apiResponseWithValue.outputLabel;
+        delete apiResponseWithValue.outputMulti;
 
         model.request = function(reqOpts, callback) {
           callback(null, apiResponseWithValue);

Original file line number	Diff line number	Diff line change
`@@ -8,3 +8,4 @@`
`8`	`8`
`9`	`9`	`Google Inc.`
`10`	`10`	`Anand Suresh`
	`11`	`+Brett Bergmann`
-Original file line number
+Diff line change
 # Keep the list alphabetically sorted.
 +Anand Suresh <[email protected]>
 +Brett Bergmann <[email protected]>
 Burcu Dogan <[email protected]>
 +Hector Rovira <[email protected]>
 Johan Euphrosine <[email protected]>
 Marco Ziccardi <[email protected]>
 Patrick Costello <[email protected]>
 Silvano Luciani <[email protected]>
 Stephen Sawchuk <[email protected]>
 -Anand Suresh <[email protected]>
 -Hector Rovira <[email protected]>