Skip to content

Commit 61d2740

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: add InstancePolicy.boot_disk (#3752)
- [ ] Regenerate this pull request now. fix: remove unsupported HTTP bindings for IAMPolicy RPCs PiperOrigin-RevId: 495371163 Source-Link: https://togithub.com/googleapis/googleapis/commit/88f1497c767747816652323799380fdd802aa79d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/0f1443aeac4081fb5d8ef2d1c0d58a08fc3dec69 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhdGNoLy5Pd2xCb3QueWFtbCIsImgiOiIwZjE0NDNhZWFjNDA4MWZiNWQ4ZWYyZDFjMGQ1OGEwOGZjM2RlYzY5In0= BEGIN_NESTED_COMMIT feat: add InstancePolicy.boot_disk fix: ServiceAccount.scopes is no longer deprecated fix: removed unused endpoints for IAM methods PiperOrigin-RevId: 495370831 Source-Link: https://togithub.com/googleapis/googleapis/commit/8f5577498f77061130d24425c3fb076a099c112b Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/44ea51b0580dd8cfa2a28c8c44093c1b73db3099 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhdGNoLy5Pd2xCb3QueWFtbCIsImgiOiI0NGVhNTFiMDU4MGRkOGNmYTJhMjhjOGM0NDA5M2MxYjczZGIzMDk5In0= END_NESTED_COMMIT
1 parent f9fc947 commit 61d2740

8 files changed

Lines changed: 52 additions & 61 deletions

File tree

‎packages/google-cloud-batch/protos/google/cloud/batch/v1/task.proto‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,7 @@ message TaskSpec {
230230
// If task ends with non-zero exit code, retry the task with max_retry_count.
231231
repeated LifecyclePolicy lifecycle_policies = 9;
232232

233-
// Environment variables to set before running the Task.
234-
// You can set up to 100 environments.
233+
// Deprecated: please use environment(non-plural) instead.
235234
map<string, string> environments = 6 [deprecated = true];
236235

237236
// Volumes to mount before running Tasks using this TaskSpec.

‎packages/google-cloud-batch/protos/google/cloud/batch/v1alpha/job.proto‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,10 @@ message AllocationPolicy {
369369
// The accelerators attached to each VM instance.
370370
repeated Accelerator accelerators = 5;
371371

372+
// Book disk to be created and attached to each VM by this InstancePolicy.
373+
// Boot disk will be deleted when the VM is deleted.
374+
Disk boot_disk = 8;
375+
372376
// Non-boot disks to be attached for each VM created by this InstancePolicy.
373377
// New disks will be deleted when the VM is deleted.
374378
repeated AttachedDisk disks = 6;
@@ -562,5 +566,5 @@ message ServiceAccount {
562566

563567
// List of scopes to be enabled for this service account on the VM, in
564568
// addition to the cloud-platform API scope that will be added by default.
565-
repeated string scopes = 2 [deprecated = true];
569+
repeated string scopes = 2;
566570
}

‎packages/google-cloud-batch/protos/google/cloud/batch/v1alpha/task.proto‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,7 @@ message TaskSpec {
238238
// If task ends with non-zero exit code, retry the task with max_retry_count.
239239
repeated LifecyclePolicy lifecycle_policies = 9;
240240

241-
// Environment variables to set before running the Task.
242-
// You can set up to 100 environments.
241+
// Deprecated: please use environment(non-plural) instead.
243242
map<string, string> environments = 6 [deprecated = true];
244243

245244
// Volumes to mount before running Tasks using this TaskSpec.

‎packages/google-cloud-batch/protos/protos.d.ts‎

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-batch/protos/protos.js‎

Lines changed: 28 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-batch/protos/protos.json‎

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-batch/src/v1/batch_service_client.ts‎

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ export class BatchServiceClient {
131131
(typeof window !== 'undefined' && typeof window?.fetch === 'function');
132132
opts = Object.assign({servicePath, port, clientConfig, fallback}, opts);
133133

134+
// Request numeric enum values if REST transport is used.
135+
opts.numericEnums = true;
136+
134137
// If scopes are unset in options and we're connecting to a non-default endpoint, set scopes just in case.
135138
if (servicePath !== staticMembers.servicePath && !('scopes' in opts)) {
136139
opts['scopes'] = staticMembers.scopes;
@@ -247,40 +250,16 @@ export class BatchServiceClient {
247250
{
248251
selector: 'google.iam.v1.IAMPolicy.GetIamPolicy',
249252
get: '/v1/{resource=projects/*/locations/*/jobs/*}:getIamPolicy',
250-
additional_bindings: [
251-
{get: '/v1/{resource=projects/*/locations/*/tasks/*}:getIamPolicy'},
252-
{get: '/v1/{resource=projects/*/locations/*/nodes/*}:getIamPolicy'},
253-
],
254253
},
255254
{
256255
selector: 'google.iam.v1.IAMPolicy.SetIamPolicy',
257256
post: '/v1/{resource=projects/*/locations/*/jobs/*}:setIamPolicy',
258257
body: '*',
259-
additional_bindings: [
260-
{
261-
post: '/v1/{resource=projects/*/locations/*/tasks/*}:setIamPolicy',
262-
body: '*',
263-
},
264-
{
265-
post: '/v1/{resource=projects/*/locations/*/nodes/*}:setIamPolicy',
266-
body: '*',
267-
},
268-
],
269258
},
270259
{
271260
selector: 'google.iam.v1.IAMPolicy.TestIamPermissions',
272261
post: '/v1/{resource=projects/*/locations/*/jobs/*}:testIamPermissions',
273262
body: '*',
274-
additional_bindings: [
275-
{
276-
post: '/v1/{resource=projects/*/locations/*/tasks/*}:testIamPermissions',
277-
body: '*',
278-
},
279-
{
280-
post: '/v1/{resource=projects/*/locations/*/nodes/*}:testIamPermissions',
281-
body: '*',
282-
},
283-
],
284263
},
285264
{
286265
selector: 'google.longrunning.Operations.CancelOperation',

‎packages/google-cloud-batch/src/v1alpha/batch_service_client.ts‎

Lines changed: 3 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ export class BatchServiceClient {
131131
(typeof window !== 'undefined' && typeof window?.fetch === 'function');
132132
opts = Object.assign({servicePath, port, clientConfig, fallback}, opts);
133133

134+
// Request numeric enum values if REST transport is used.
135+
opts.numericEnums = true;
136+
134137
// If scopes are unset in options and we're connecting to a non-default endpoint, set scopes just in case.
135138
if (servicePath !== staticMembers.servicePath && !('scopes' in opts)) {
136139
opts['scopes'] = staticMembers.scopes;
@@ -247,44 +250,16 @@ export class BatchServiceClient {
247250
{
248251
selector: 'google.iam.v1.IAMPolicy.GetIamPolicy',
249252
get: '/v1alpha/{resource=projects/*/locations/*/jobs/*}:getIamPolicy',
250-
additional_bindings: [
251-
{
252-
get: '/v1alpha/{resource=projects/*/locations/*/tasks/*}:getIamPolicy',
253-
},
254-
{
255-
get: '/v1alpha/{resource=projects/*/locations/*/nodes/*}:getIamPolicy',
256-
},
257-
],
258253
},
259254
{
260255
selector: 'google.iam.v1.IAMPolicy.SetIamPolicy',
261256
post: '/v1alpha/{resource=projects/*/locations/*/jobs/*}:setIamPolicy',
262257
body: '*',
263-
additional_bindings: [
264-
{
265-
post: '/v1alpha/{resource=projects/*/locations/*/tasks/*}:setIamPolicy',
266-
body: '*',
267-
},
268-
{
269-
post: '/v1alpha/{resource=projects/*/locations/*/nodes/*}:setIamPolicy',
270-
body: '*',
271-
},
272-
],
273258
},
274259
{
275260
selector: 'google.iam.v1.IAMPolicy.TestIamPermissions',
276261
post: '/v1alpha/{resource=projects/*/locations/*/jobs/*}:testIamPermissions',
277262
body: '*',
278-
additional_bindings: [
279-
{
280-
post: '/v1alpha/{resource=projects/*/locations/*/tasks/*}:testIamPermissions',
281-
body: '*',
282-
},
283-
{
284-
post: '/v1alpha/{resource=projects/*/locations/*/nodes/*}:testIamPermissions',
285-
body: '*',
286-
},
287-
],
288263
},
289264
{
290265
selector: 'google.longrunning.Operations.CancelOperation',

0 commit comments

Comments
 (0)