bigquery: check for apiResponse presence (#1853)

stephenplusplus · web-flow · commit 61b04a1ea22e · 2016-12-02T14:31:09.000-05:00
diff --git a/packages/bigquery/src/job.js b/packages/bigquery/src/job.js
@@ -317,7 +317,7 @@ Job.prototype.getQueryResultsStream = function(options) {
  */
 Job.prototype.poll_ = function(callback) {
   this.getMetadata(function(err, metadata, apiResponse) {
-    if (apiResponse.status && apiResponse.status.errors) {
+    if (!err && apiResponse.status && apiResponse.status.errors) {
       err = common.util.ApiError(apiResponse.status);
     }
 
diff --git a/packages/bigquery/test/job.js b/packages/bigquery/test/job.js
@@ -277,11 +277,10 @@ describe('BigQuery/Job', function() {
 
     describe('API error', function() {
       var error = new Error('Error.');
-      var apiResponse = {};
 
       beforeEach(function() {
         job.getMetadata = function(callback) {
-          callback(error, null, apiResponse);
+          callback(error);
         };
       });
 

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ Job.prototype.getQueryResultsStream = function(options) {`
`317`	`317`	`*/`
`318`	`318`	`Job.prototype.poll_ = function(callback) {`
`319`	`319`	`this.getMetadata(function(err, metadata, apiResponse) {`
`320`		`- if (apiResponse.status && apiResponse.status.errors) {`
	`320`	`+ if (!err && apiResponse.status && apiResponse.status.errors) {`
`321`	`321`	`err = common.util.ApiError(apiResponse.status);`
`322`	`322`	`}`
`323`	`323`