Skip to content

Commit 618c238

Browse files
stephenplusplusjmdobry
authored andcommitted
tweaks to make the install successful & tests run (#2)
1 parent 436466d commit 618c238

5 files changed

Lines changed: 11 additions & 7 deletions

File tree

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
"through2": "^2.0.0"
2121
},
2222
"scripts": {
23+
"link-modules": "node ./scripts/link",
24+
"install-module-dependencies": "node ./scripts/install",
25+
"postinstall": "npm run link-modules && npm run install-module-dependencies",
2326
"docs": "node ./scripts/docs.js",
2427
"lint": "jshint packages/ system-test/ test/ && jscs packages/ system-test/ test/",
2528
"test": "npm run docs && mocha test/docs.js packages/*/test/*.js",
2629
"system-test": "mocha packages/*/system-test/*.js --no-timeouts --bail",
27-
"postinstall": "node ./scripts/install",
2830
"coveralls": "istanbul cover _mocha --report lcovonly -- --no-timeouts --bail packages/*/test/*.js -R spec && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage"
2931
},
3032
"license": "Apache-2.0",

packages/common/src/util.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,9 @@ util.extendGlobalConfig = extendGlobalConfig;
547547
function normalizeArguments(globalContext, localConfig, options) {
548548
options = options || {};
549549

550-
var config = util.extendGlobalConfig(globalContext.config_, localConfig);
550+
var globalConfig = globalContext && globalContext.config_;
551+
552+
var config = util.extendGlobalConfig(globalConfig, localConfig);
551553

552554
if (options.projectIdRequired !== false && !config.projectId) {
553555
throw util.missingProjectIdError;

packages/google-cloud/system-test/google-cloud.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
var assert = require('assert');
2020
var env = require('../../../system-test/env.js');
21-
var gcloud = require('../lib');
21+
var gcloud = require('../');
2222
var path = require('path');
2323

2424
// Test used to confirm we can perform a successful API operation.

packages/logging/system-test/logging.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ var prop = require('propprop');
2525
var uuid = require('node-uuid');
2626

2727
var env = require('../../../system-test/env.js');
28-
var BigQuery = require('@google-cloud/bigquery/index.js');
28+
var BigQuery = require('@google-cloud/bigquery');
2929
var Logging = require('../');
30-
var PubSub = require('@google-cloud/pubsub/index.js');
31-
var Storage = require('@google-cloud/storage/index.js');
30+
var PubSub = require('@google-cloud/pubsub');
31+
var Storage = require('@google-cloud/storage');
3232

3333
describe('Logging', function() {
3434
var TESTS_PREFIX = 'gcloud-logging-test';

packages/translate/system-test/translate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var extend = require('extend');
2121
var prop = require('propprop');
2222

2323
var env = require('../../../system-test/env.js');
24-
var Translate = require('../lib/translate/index.js').Translate;
24+
var Translate = require('../').Translate;
2525

2626
var API_KEY = process.env.GCLOUD_TESTS_API_KEY;
2727

0 commit comments

Comments
 (0)