Skip to content

Commit 5e386b6

Browse files
gcf-owl-bot[bot]d-goog
gcf-owl-bot[bot]
and
d-goog
authored
fix: [networkservices] Add client library version to headers (#5070)
* docs: updates DEP proto comments PiperOrigin-RevId: 609406502 Source-Link: googleapis/googleapis@2f14a03 Source-Link: googleapis/googleapis-gen@75c8f1c Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmtzZXJ2aWNlcy8uT3dsQm90LnlhbWwiLCJoIjoiNzVjOGYxY2Y3M2E1OGZmZWRhZWYyNTU2OTY3Y2M2Y2UzNDRiNmNmNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix: Add client library version to headers fix: Allow bundlers to bundle JSON files correctly for ESM deps: Update dependency google-gax to ^4.3.1 fix: Export types from protos in ESM PiperOrigin-RevId: 609821360 Source-Link: googleapis/googleapis@5c5ecf0 Source-Link: googleapis/googleapis-gen@b875fcd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW5ldHdvcmtzZXJ2aWNlcy8uT3dsQm90LnlhbWwiLCJoIjoiYjg3NWZjZGQxNGI0ZGVmNjUyMTgyOTMwMDNkOWJlYzRiODQyZWNhNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel Bankhead <[email protected]>
1 parent e7b43e8 commit 5e386b6

2 files changed

Lines changed: 22 additions & 20 deletions

File tree

  • packages/google-cloud-networkservices/protos

‎packages/google-cloud-networkservices/protos/google/cloud/networkservices/v1beta1/dep.proto‎

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ service DepService {
165165
}
166166

167167
// Load balancing schemes supported by the `LbTrafficExtension` resource and
168-
// `LbRouteExtension` resource. The valid values are: `INTERNAL_MANAGED`,
168+
// `LbRouteExtension` resource. The valid values are `INTERNAL_MANAGED` and
169169
// `EXTERNAL_MANAGED`.
170170
// For more information, refer to [Choosing a load
171171
// balancer](https://cloud.google.com/load-balancing/docs/backend-service).
@@ -191,13 +191,13 @@ message ExtensionChain {
191191
//
192192
// For more information, see
193193
// [CEL matcher language
194-
// reference](https://cloud.google.com/service-extensions/docs/cel-matcher-language-reference).
194+
// reference](/service-extensions/docs/cel-matcher-language-reference).
195195
string cel_expression = 1 [(google.api.field_behavior) = REQUIRED];
196196
}
197197

198198
// A single extension in the chain to execute for the matching request.
199199
message Extension {
200-
// Defines the part of the request or response for which this extension
200+
// The part of the request or response for which this extension
201201
// is called.
202202
// The valid values are:
203203
// `REQUEST_HEADERS`, `REQUEST_BODY`, `RESPONSE_HEADERS`, `RESPONSE_BODY`.
@@ -230,15 +230,15 @@ message ExtensionChain {
230230
// last a letter or a number.
231231
string name = 1 [(google.api.field_behavior) = REQUIRED];
232232

233-
// Required. The `:authority` header in the gRPC request sent from Envoy
233+
// Optional. The `:authority` header in the gRPC request sent from Envoy
234234
// to the extension service.
235-
string authority = 2 [(google.api.field_behavior) = REQUIRED];
235+
string authority = 2 [(google.api.field_behavior) = OPTIONAL];
236236

237237
// Required. The reference to the service that runs the extension.
238238
//
239-
// Currently only Callout extensions are supported here.
239+
// Currently only callout extensions are supported here.
240240
//
241-
// To configure a Callout extension, `service` must be a fully-qualified
241+
// To configure a callout extension, `service` must be a fully-qualified
242242
// reference
243243
// to a [backend
244244
// service](https://cloud.google.com/compute/docs/reference/rest/v1/backendServices)
@@ -262,17 +262,17 @@ message ExtensionChain {
262262

263263
// Optional. Determines how the proxy behaves if the call to the extension
264264
// fails or times out.
265+
//
265266
// When set to `TRUE`, request or response processing continues without
266267
// error. Any subsequent extensions in the extension chain are also
267-
// executed. When set to `FALSE`:
268-
// * If response headers have not been delivered to the downstream
269-
// client, a generic 500 error is returned to the client. The error
270-
// response can be tailored by configuring a custom error response
271-
// in the load balancer.
268+
// executed. When set to `FALSE` or the default setting of `FALSE` is used,
269+
// one of the following happens:
270+
// * If response headers have not been delivered to the downstream client,
271+
// a generic 500 error is returned to the client. The error response can be
272+
// tailored by configuring a custom error response in the load balancer.
272273
//
273-
// * If response headers have been delivered, then the HTTP stream to
274-
// the downstream client is reset.
275-
// Default is `FALSE`.
274+
// * If response headers have been delivered, then the HTTP stream to the
275+
// downstream client is reset.
276276
bool fail_open = 6 [(google.api.field_behavior) = OPTIONAL];
277277

278278
// Optional. List of the HTTP headers to forward to the extension
@@ -334,8 +334,9 @@ message LbTrafficExtension {
334334

335335
// Optional. Set of labels associated with the `LbTrafficExtension` resource.
336336
//
337-
// The format must comply with [the following
338-
// requirements](/compute/docs/labeling-resources#requirements).
337+
// The format must comply with [the requirements for
338+
// labels](/compute/docs/labeling-resources#requirements) for Google Cloud
339+
// resources.
339340
map<string, string> labels = 4 [(google.api.field_behavior) = OPTIONAL];
340341

341342
// Required. A list of references to the forwarding rules to which this
@@ -545,8 +546,9 @@ message LbRouteExtension {
545546

546547
// Optional. Set of labels associated with the `LbRouteExtension` resource.
547548
//
548-
// The format must comply with [the following
549-
// requirements](/compute/docs/labeling-resources#requirements).
549+
// The format must comply with [the requirements for
550+
// labels](/compute/docs/labeling-resources#requirements) for Google Cloud
551+
// resources.
550552
map<string, string> labels = 4 [(google.api.field_behavior) = OPTIONAL];
551553

552554
// Required. A list of references to the forwarding rules to which this

‎packages/google-cloud-networkservices/protos/protos.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)