Skip to content

Commit 5b4b0d3

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: [apphub] add enum Type.GLOBAL (#6215)
* feat: add enum `Type.GLOBAL` docs: misc comment updates, formatting PiperOrigin-RevId: 740451864 Source-Link: googleapis/googleapis@f4a56c1 Source-Link: googleapis/googleapis-gen@ebeea90 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWFwcGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWJlZWE5MDFmNWNhOGU1MGJmOWJmZDI3MzRkZjUzZTE3ZmY4YjIwMiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent f530220 commit 5b4b0d3

8 files changed

Lines changed: 38 additions & 25 deletions

File tree

‎packages/google-cloud-apphub/protos/google/cloud/apphub/v1/apphub_service.proto‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,9 +1098,10 @@ message OperationMetadata {
10981098

10991099
// Output only. Identifies whether the user has requested cancellation
11001100
// of the operation. Operations that have been cancelled successfully
1101-
// have [Operation.error][] value with a
1102-
// [google.rpc.Status.code][google.rpc.Status.code] of 1, corresponding to
1103-
// `Code.CANCELLED`.
1101+
// have
1102+
// [google.longrunning.Operation.error][google.longrunning.Operation.error]
1103+
// value with a [google.rpc.Status.code][google.rpc.Status.code] of 1,
1104+
// corresponding to `Code.CANCELLED`.
11041105
bool requested_cancellation = 6 [(google.api.field_behavior) = OUTPUT_ONLY];
11051106

11061107
// Output only. API version used to start the operation.

‎packages/google-cloud-apphub/protos/google/cloud/apphub/v1/application.proto‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ option java_package = "com.google.cloud.apphub.v1";
3030
option php_namespace = "Google\\Cloud\\AppHub\\V1";
3131
option ruby_package = "Google::Cloud::AppHub::V1";
3232

33-
// Application defines the governance boundary for App Hub Entities that
33+
// Application defines the governance boundary for App Hub entities that
3434
// perform a logical end-to-end business function.
3535
// App Hub supports application level IAM permission to align with governance
3636
// requirements.
@@ -58,7 +58,7 @@ message Application {
5858
}
5959

6060
// Identifier. The resource name of an Application. Format:
61-
// "projects/{host-project-id}/locations/{location}/applications/{application-id}"
61+
// `"projects/{host-project-id}/locations/{location}/applications/{application-id}"`
6262
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
6363

6464
// Optional. User-defined name for the Application.
@@ -107,6 +107,9 @@ message Scope {
107107

108108
// Regional type.
109109
REGIONAL = 1;
110+
111+
// Global type.
112+
GLOBAL = 2;
110113
}
111114

112115
// Required. Scope Type.

‎packages/google-cloud-apphub/protos/google/cloud/apphub/v1/service.proto‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ option php_namespace = "Google\\Cloud\\AppHub\\V1";
3131
option ruby_package = "Google::Cloud::AppHub::V1";
3232

3333
// Service is an App Hub data model that contains a discovered service, which
34-
// represents a network/api interface that exposes some functionality to clients
35-
// for consumption over the network.
34+
// represents a network or API interface that exposes some functionality to
35+
// clients for consumption over the network.
3636
message Service {
3737
option (google.api.resource) = {
3838
type: "apphub.googleapis.com/Service"
@@ -60,7 +60,7 @@ message Service {
6060
}
6161

6262
// Identifier. The resource name of a Service. Format:
63-
// "projects/{host-project-id}/locations/{location}/applications/{application-id}/services/{service-id}"
63+
// `"projects/{host-project-id}/locations/{location}/applications/{application-id}/services/{service-id}"`
6464
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
6565

6666
// Optional. User-defined name for the Service.
@@ -114,8 +114,8 @@ message Service {
114114

115115
// Reference to an underlying networking resource that can comprise a Service.
116116
message ServiceReference {
117-
// Output only. The underlying resource URI (For example, URI of Forwarding
118-
// Rule, URL Map, and Backend Service).
117+
// Output only. The underlying resource URI. For example, URI of Forwarding
118+
// Rule, URL Map, and Backend Service.
119119
string uri = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
120120
}
121121

@@ -134,9 +134,9 @@ message ServiceProperties {
134134
string zone = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
135135
}
136136

137-
// DiscoveredService is a network/api interface that exposes some functionality
138-
// to clients for consumption over the network. A discovered service can be
139-
// registered to a App Hub service.
137+
// DiscoveredService is a network or API interface that exposes some
138+
// functionality to clients for consumption over the network. A discovered
139+
// service can be registered to a App Hub service.
140140
message DiscoveredService {
141141
option (google.api.resource) = {
142142
type: "apphub.googleapis.com/DiscoveredService"
@@ -146,7 +146,7 @@ message DiscoveredService {
146146
};
147147

148148
// Identifier. The resource name of the discovered service. Format:
149-
// "projects/{host-project-id}/locations/{location}/discoveredServices/{uuid}""
149+
// `"projects/{host-project-id}/locations/{location}/discoveredServices/{uuid}"`
150150
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
151151

152152
// Output only. Reference to an underlying networking resource that can

‎packages/google-cloud-apphub/protos/google/cloud/apphub/v1/service_project_attachment.proto‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ message ServiceProjectAttachment {
6060
}
6161

6262
// Identifier. The resource name of a ServiceProjectAttachment. Format:
63-
// "projects/{host-project-id}/locations/global/serviceProjectAttachments/{service-project-id}."
63+
// `"projects/{host-project-id}/locations/global/serviceProjectAttachments/{service-project-id}."`
6464
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
6565

66-
// Required. Immutable. Service project name in the format: "projects/abc" or
67-
// "projects/123". As input, project name with either project id or number are
68-
// accepted. As output, this field will contain project number.
66+
// Required. Immutable. Service project name in the format: `"projects/abc"`
67+
// or `"projects/123"`. As input, project name with either project id or
68+
// number are accepted. As output, this field will contain project number.
6969
string service_project = 2 [
7070
(google.api.field_behavior) = REQUIRED,
7171
(google.api.field_behavior) = IMMUTABLE,

‎packages/google-cloud-apphub/protos/google/cloud/apphub/v1/workload.proto‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ message Workload {
6161
}
6262

6363
// Identifier. The resource name of the Workload. Format:
64-
// "projects/{host-project-id}/locations/{location}/applications/{application-id}/workloads/{workload-id}"
64+
// `"projects/{host-project-id}/locations/{location}/applications/{application-id}/workloads/{workload-id}"`
6565
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
6666

6767
// Optional. User-defined name for the Workload.
@@ -122,15 +122,15 @@ message WorkloadReference {
122122
// Properties of an underlying compute resource represented by the Workload.
123123
message WorkloadProperties {
124124
// Output only. The service project identifier that the underlying cloud
125-
// resource resides in. Empty for non cloud resources.
125+
// resource resides in. Empty for non-cloud resources.
126126
string gcp_project = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
127127

128128
// Output only. The location that the underlying compute resource resides in
129-
// (e.g us-west1).
129+
// (for example, us-west1).
130130
string location = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
131131

132132
// Output only. The location that the underlying compute resource resides in
133-
// if it is zonal (e.g us-west1-a).
133+
// if it is zonal (for example, us-west1-a).
134134
string zone = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
135135
}
136136

@@ -147,7 +147,7 @@ message DiscoveredWorkload {
147147
};
148148

149149
// Identifier. The resource name of the discovered workload. Format:
150-
// "projects/{host-project-id}/locations/{location}/discoveredWorkloads/{uuid}"
150+
// `"projects/{host-project-id}/locations/{location}/discoveredWorkloads/{uuid}"`
151151
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
152152

153153
// Output only. Reference of an underlying compute resource represented by the

‎packages/google-cloud-apphub/protos/protos.d.ts‎

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-apphub/protos/protos.js‎

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-apphub/protos/protos.json‎

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)