add start option

stephenplusplus · stephenplusplus · commit 457e8827fff2 · 2016-08-29T13:26:06.000-04:00
diff --git a/packages/compute/src/vm.js b/packages/compute/src/vm.js
@@ -424,17 +424,46 @@ VM.prototype.reset = function(callback) {
  * @param {string} machineType - Full or partial machine type. See a list of
  *     predefined machine types
  *     [here](https://cloud.google.com/compute/docs/machine-types#predefined_machine_types).
+ * @param {object=} options - Configuration object.
+ * @param {boolean} options.start - Start the VM after successfully updating the
+ *     machine type. Default: `false`.
  * @param {function} callback - The callback function.
  * @param {?error} callback.err - An error returned while making this request.
  * @param {object} callback.apiResponse - The full API response.
  *
  * @example
- * vm.resize('n1-standard-1', function(err, apiResponse) {});
+ * vm.resize('n1-standard-1', function(err, apiResponse) {
+ *   if (!err) {
+ *     // The VM is running and its machine type was changed successfully.
+ *   }
+ * });
+ *
+ * //-
+ * // By default, calling `resize` will start your server after updating its
+ * // machine type. If you want to leave it stopped, set `options.start` to
+ * // `false`.
+ * //-
+ * var options = {
+ *   start: false
+ * };
+ *
+ * vm.resize('ns-standard-1', options, function(err, apiResponse) {
+ *   if (!err) {
+ *     // The VM is stopped and its machine type was changed successfully.
+ *   }
+ * });
  */
-VM.prototype.resize = function(machineType, callback) {
+VM.prototype.resize = function(machineType, options, callback) {
   var self = this;
   var compute = this.zone.parent;
 
+  if (is.fn(options)) {
+    callback = options;
+    options = {};
+  }
+
+  options = options || {};
+
   var isPartialMachineType = machineType.indexOf('/') === -1;
 
   if (isPartialMachineType) {
@@ -469,8 +498,12 @@ VM.prototype.resize = function(machineType, callback) {
       return;
     }
 
-    // The machine type was changed successfully. Start the VM.
-    self.start(compute.execAfterOperation_(callback));
+    // The machine type was changed successfully.
+    if (options.start === false) {
+      callback(null, apiResponse);
+    } else {
+      self.start(compute.execAfterOperation_(callback));
+    }
   }));
 };
 
diff --git a/packages/compute/test/vm.js b/packages/compute/test/vm.js
@@ -611,7 +611,7 @@ describe('VM', function() {
     });
 
     describe('success', function() {
-      it('should start the VM', function(done) {
+      it('should start the VM by default', function(done) {
         function userCallback() {}
         function onVmStart() {}
 
@@ -632,6 +632,24 @@ describe('VM', function() {
         vm.resize(MACHINE_TYPE, userCallback);
       });
     });
+
+    it('should not start the VM by request', function(done) {
+      var apiResponse = {};
+
+      vm.zone.parent.execAfterOperation_ = function(callback) {
+        callback(null, apiResponse);
+      };
+
+      vm.start = function() {
+        done(); // Test will fail if called.
+      };
+
+      vm.resize(MACHINE_TYPE, { start: false }, function(err, apiResponse_) {
+        assert.ifError(err);
+        assert.strictEqual(apiResponse_, apiResponse);
+        done();
+      });
+    });
   });
 
   describe('setMetadata', function() {
