Skip to content

Commit 24ad294

Browse files
fix : disable afe_connectivity_error_count metric (#2417)
* fix : disable afe_connectivity_error_count metric * fix: disable afe_connectivity_error_count metric * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 6e27c45 commit 24ad294

3 files changed

Lines changed: 4 additions & 10 deletions

File tree

handwritten/spanner/src/metrics/interceptor.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ export const MetricInterceptor = (options, nextCall) => {
6767
if (metricsTracer?.afeLatency) {
6868
metricsTracer?.recordAfeLatency(status.code);
6969
} else {
70-
metricsTracer?.recordAfeConnectivityErrorCount(status.code);
70+
// Disable afe_connectivity_error_count metric as AFE header is disabled in backend
71+
// currently.
72+
// metricsTracer?.recordAfeConnectivityErrorCount(status.code);
7173
}
7274
},
7375
};

handwritten/spanner/test/metrics/interceptor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ describe('MetricInterceptor', () => {
193193
);
194194
});
195195

196-
it('AFE Metrics - Connectivity Error Count', () => {
196+
it.skip('AFE Metrics - Connectivity Error Count', () => {
197197
const interceptingCall = MetricInterceptor(mockOptions, mockNextCall);
198198
interceptingCall.start(testMetadata, mockListener);
199199

handwritten/spanner/test/metrics/metrics.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -457,10 +457,6 @@ describe('Test metrics with mock server', () => {
457457
resourceMetrics,
458458
METRIC_NAME_GFE_CONNECTIVITY_ERROR_COUNT,
459459
);
460-
const afeConnectivityErrorCountData = getMetricData(
461-
resourceMetrics,
462-
METRIC_NAME_AFE_CONNECTIVITY_ERROR_COUNT,
463-
);
464460

465461
// Verify GFE AFE latency doesn't exist
466462
assert.ok(!hasMetricData(resourceMetrics, METRIC_NAME_GFE_LATENCIES));
@@ -486,10 +482,6 @@ describe('Test metrics with mock server', () => {
486482
getAggregatedValue(connectivityErrorCountData, attributes),
487483
1,
488484
);
489-
assert.strictEqual(
490-
getAggregatedValue(afeConnectivityErrorCountData, attributes),
491-
1,
492-
);
493485
});
494486
});
495487

0 commit comments

Comments
 (0)