Initial commit

DominicKramer · DominicKramer · commit 12b113116d6c · 2017-04-18T15:35:31.000-07:00
diff --git a/packages/error-reporting/src/logger.js b/packages/error-reporting/src/logger.js
@@ -41,18 +41,19 @@ var logger = require('@google-cloud/common').logger;
  */
 function createLogger(initConfiguration) {
   // Default to log level: warn (2)
-  var level = logger.WARN;
+  var DEFAULT_LEVEL = logger.LEVELS[2];
+  var level = DEFAULT_LEVEL;
   if (has(process.env, 'GCLOUD_ERRORS_LOGLEVEL')) {
     // Cast env string as integer
     level = logger.LEVELS[~~process.env.GCLOUD_ERRORS_LOGLEVEL] ||
-      logger.LEVELS.warn;
+      DEFAULT_LEVEL;
   } else if (isObject(initConfiguration) &&
     has(initConfiguration, 'logLevel')) {
     if (isString(initConfiguration.logLevel)) {
       // Cast string as integer
-      level = logger.LEVELS[~~initConfiguration.logLevel] || logger.LEVELS.warn;
+      level = logger.LEVELS[~~initConfiguration.logLevel] || DEFAULT_LEVEL;
     } else if (isNumber(initConfiguration.logLevel)) {
-      level = logger.LEVELS[initConfiguration.logLevel] || logger.LEVELS.warn;
+      level = logger.LEVELS[initConfiguration.logLevel] || DEFAULT_LEVEL;
     } else {
       throw new Error('config.logLevel must be a number or decimal ' +
         'representation of a number in string form');
diff --git a/packages/error-reporting/test/unit/testLogger.js b/packages/error-reporting/test/unit/testLogger.js
@@ -52,9 +52,33 @@ describe('logger', function() {
       });
     });
     describe('Default log level', function() {
+      var oldLog;
+      var text;
+      beforeEach(function() {
+        oldLog = console.log;
+        text = '';
+        console.log = function() {
+          oldLog.apply(this, arguments);
+          for (var i=0; i<arguments.length; i++) {
+            text += arguments[i];
+          }
+        };
+      });
+     afterEach(function() {
+        text = undefined;
+        console.log = oldLog;
+      });
       it('Should be able to WARN by default', function() {
         var logger = createLogger();
         logger.warn('test warning message');
+        assert.strictEqual(text,
+          'WARN:@google/cloud-errors: test warning message');
+      });
+      it('Should be able to ERROR by default', function() {
+        var logger = createLogger();
+        logger.error('test error message');
+        assert.strictEqual(text,
+          'ERROR:@google/cloud-errors: test error message');
       });
     });
   });
