Skip to content

Commit 10bb492

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: [deploy] Add support for disabling Pod overprovisioning in the progressive deployment strategy configuration for a Kubernetes Target (#4317)
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 537857136 Source-Link: https://togithub.com/googleapis/googleapis/commit/a7658127bcfc80102023ed0c4474f5a5c92813c1 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/7c8cf36e390b92a2bc403b17d5fc2b59a60d8f85 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRlcGxveS8uT3dsQm90LnlhbWwiLCJoIjoiN2M4Y2YzNmUzOTBiOTJhMmJjNDAzYjE3ZDVmYzJiNTlhNjBkOGY4NSJ9
1 parent d266f18 commit 10bb492

8 files changed

Lines changed: 75 additions & 51 deletions

File tree

‎packages/google-cloud-deploy/README.md‎

Lines changed: 29 additions & 30 deletions
Large diffs are not rendered by default.

‎packages/google-cloud-deploy/protos/google/cloud/deploy/v1/cloud_deploy.proto‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,6 +521,13 @@ message KubernetesConfig {
521521
// Required. Name of the Kubernetes Deployment whose traffic is managed by
522522
// the specified Service.
523523
string deployment = 2 [(google.api.field_behavior) = REQUIRED];
524+
525+
// Optional. Whether to disable Pod overprovisioning. If Pod
526+
// overprovisioning is disabled then Cloud Deploy will limit the number of
527+
// total Pods used for the deployment strategy to the number of Pods the
528+
// Deployment has on the cluster.
529+
bool disable_pod_overprovisioning = 3
530+
[(google.api.field_behavior) = OPTIONAL];
524531
}
525532

526533
// The service definition configuration.
@@ -1175,7 +1182,7 @@ message DeleteTargetRequest {
11751182
string request_id = 2 [(google.api.field_behavior) = OPTIONAL];
11761183

11771184
// Optional. If set to true, then deleting an already deleted or non-existing
1178-
// DeliveryPipeline will succeed.
1185+
// `Target` will succeed.
11791186
bool allow_missing = 3 [(google.api.field_behavior) = OPTIONAL];
11801187

11811188
// Optional. If set, validate the request and preview the review, but do not

‎packages/google-cloud-deploy/protos/protos.d.ts‎

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-deploy/protos/protos.js‎

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-deploy/protos/protos.json‎

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/google-cloud-deploy/samples/README.md‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
* [Cloud_deploy.update_delivery_pipeline](#cloud_deploy.update_delivery_pipeline)
4040
* [Cloud_deploy.update_target](#cloud_deploy.update_target)
4141
* [Quickstart](#quickstart)
42-
* [Quickstart](#quickstart)
4342

4443
## Before you begin
4544

@@ -510,23 +509,6 @@ __Usage:__
510509
`node packages/google-cloud-deploy/samples/quickstart.js`
511510

512511

513-
-----
514-
515-
516-
517-
518-
### Quickstart
519-
520-
View the [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-deploy/samples/test/quickstart.js).
521-
522-
[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/google-cloud-node&page=editor&open_in_editor=packages/google-cloud-deploy/samples/test/quickstart.js,samples/README.md)
523-
524-
__Usage:__
525-
526-
527-
`node packages/google-cloud-deploy/samples/test/quickstart.js`
528-
529-
530512

531513

532514

‎packages/google-cloud-deploy/samples/generated/v1/cloud_deploy.delete_target.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function main(name) {
4949
// const requestId = 'abc123'
5050
/**
5151
* Optional. If set to true, then deleting an already deleted or non-existing
52-
* DeliveryPipeline will succeed.
52+
* `Target` will succeed.
5353
*/
5454
// const allowMissing = true
5555
/**

‎packages/google-cloud-deploy/src/v1/cloud_deploy_client.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2585,7 +2585,7 @@ export class CloudDeployClient {
25852585
* not supported (00000000-0000-0000-0000-000000000000).
25862586
* @param {boolean} [request.allowMissing]
25872587
* Optional. If set to true, then deleting an already deleted or non-existing
2588-
* DeliveryPipeline will succeed.
2588+
* `Target` will succeed.
25892589
* @param {boolean} [request.validateOnly]
25902590
* Optional. If set, validate the request and preview the review, but do not
25912591
* actually post it.

0 commit comments

Comments
 (0)