Skip to content

Commit 0eab6d4

Browse files
gcf-owl-bot[bot]sofisl
gcf-owl-bot[bot]
and
sofisl
authored
fix: [Many APIs] await/catch promises, and update listOperationsAsync return type (#6189)
* feat: await/catch promises, and update listOperationsAsync return type PiperOrigin-RevId: 738212310 Source-Link: googleapis/googleapis@803b234 Source-Link: googleapis/googleapis-gen@4f44bd2 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXRleHR0b3NwZWVjaC8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXRwdS8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXRyYW5zbGF0ZS8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZpZGVvLWxpdmVzdHJlYW0vLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZpZGVvLXN0aXRjaGVyLy5Pd2xCb3QueWFtbCIsImgiOiI0ZjQ0YmQyYmFhOGRkNWE3MWNhMGNlYmRiMTY0YzNjMzQzNDFlZDg3In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZpZGVvLXRyYW5zY29kZXIvLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZpZGVvaW50ZWxsaWdlbmNlLy5Pd2xCb3QueWFtbCIsImgiOiI0ZjQ0YmQyYmFhOGRkNWE3MWNhMGNlYmRiMTY0YzNjMzQzNDFlZDg3In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZpc2lvbi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtbWlncmF0aW9uLy5Pd2xCb3QueWFtbCIsImgiOiI0ZjQ0YmQyYmFhOGRkNWE3MWNhMGNlYmRiMTY0YzNjMzQzNDFlZDg3In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZtd2FyZWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXZwY2FjY2Vzcy8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXdlYnJpc2svLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXdlYnNlY3VyaXR5c2Nhbm5lci8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXdvcmtmbG93cy1leGVjdXRpb25zLy5Pd2xCb3QueWFtbCIsImgiOiI0ZjQ0YmQyYmFhOGRkNWE3MWNhMGNlYmRiMTY0YzNjMzQzNDFlZDg3In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXdvcmtzdGF0aW9ucy8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNvbnRhaW5lci8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWRhdGFmbG93Ly5Pd2xCb3QueWFtbCIsImgiOiI0ZjQ0YmQyYmFhOGRkNWE3MWNhMGNlYmRiMTY0YzNjMzQzNDFlZDg3In0= Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWRldnRvb2xzLWFydGlmYWN0cmVnaXN0cnkvLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWRldnRvb2xzLWNsb3VkYnVpbGQvLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWRldnRvb2xzLWNsb3VkcHJvZmlsZXIvLk93bEJvdC55YW1sIiwiaCI6IjRmNDRiZDJiYWE4ZGQ1YTcxY2EwY2ViZGIxNjRjM2MzNDM0MWVkODcifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update gax --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]> Co-authored-by: sofisl <[email protected]>
1 parent 2fcd202 commit 0eab6d4

202 files changed

Lines changed: 7185 additions & 5245 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎packages/google-cloud-texttospeech/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"test": "c8 mocha build/test"
4949
},
5050
"dependencies": {
51-
"google-gax": "^5.0.0-rc.0"
51+
"google-gax": "^5.0.1-rc.0"
5252
},
5353
"devDependencies": {
5454
"@types/mocha": "^10.0.10",

‎packages/google-cloud-texttospeech/samples/generated/v1/snippet_metadata.google.cloud.texttospeech.v1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-texttospeech",
4-
"version": "5.8.1",
4+
"version": "6.0.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-texttospeech/samples/generated/v1/snippet_metadata_google.cloud.texttospeech.v1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-texttospeech",
4-
"version": "5.8.1",
4+
"version": "6.0.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-texttospeech/samples/generated/v1beta1/snippet_metadata.google.cloud.texttospeech.v1beta1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-texttospeech",
4-
"version": "5.8.1",
4+
"version": "6.0.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-texttospeech/samples/generated/v1beta1/snippet_metadata_google.cloud.texttospeech.v1beta1.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"clientLibrary": {
33
"name": "nodejs-texttospeech",
4-
"version": "5.8.1",
4+
"version": "6.0.0",
55
"language": "TYPESCRIPT",
66
"apis": [
77
{

‎packages/google-cloud-texttospeech/src/v1/text_to_speech_client.ts‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,9 @@ export class TextToSpeechClient {
478478
options = options || {};
479479
options.otherArgs = options.otherArgs || {};
480480
options.otherArgs.headers = options.otherArgs.headers || {};
481-
this.initialize();
481+
this.initialize().catch(err => {
482+
throw err;
483+
});
482484
this._log.info('listVoices request %j', request);
483485
const wrappedCallback:
484486
| Callback<
@@ -597,7 +599,9 @@ export class TextToSpeechClient {
597599
options = options || {};
598600
options.otherArgs = options.otherArgs || {};
599601
options.otherArgs.headers = options.otherArgs.headers || {};
600-
this.initialize();
602+
this.initialize().catch(err => {
603+
throw err;
604+
});
601605
this._log.info('synthesizeSpeech request %j', request);
602606
const wrappedCallback:
603607
| Callback<
@@ -646,7 +650,9 @@ export class TextToSpeechClient {
646650
* region_tag:texttospeech_v1_generated_TextToSpeech_StreamingSynthesize_async
647651
*/
648652
streamingSynthesize(options?: CallOptions): gax.CancellableStream {
649-
this.initialize();
653+
this.initialize().catch(err => {
654+
throw err;
655+
});
650656
this._log.info('streamingSynthesize stream %j', options);
651657
return this.innerApiCalls.streamingSynthesize(null, options);
652658
}

‎packages/google-cloud-texttospeech/src/v1/text_to_speech_long_audio_synthesize_client.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,9 @@ export class TextToSpeechLongAudioSynthesizeClient {
513513
this._gaxModule.routingHeader.fromParams({
514514
parent: request.parent ?? '',
515515
});
516-
this.initialize();
516+
this.initialize().catch(err => {
517+
throw err;
518+
});
517519
const wrappedCallback:
518520
| Callback<
519521
LROperation<
@@ -675,7 +677,7 @@ export class TextToSpeechLongAudioSynthesizeClient {
675677
listOperationsAsync(
676678
request: protos.google.longrunning.ListOperationsRequest,
677679
options?: gax.CallOptions
678-
): AsyncIterable<protos.google.longrunning.ListOperationsResponse> {
680+
): AsyncIterable<protos.google.longrunning.IOperation> {
679681
options = options || {};
680682
options.otherArgs = options.otherArgs || {};
681683
options.otherArgs.headers = options.otherArgs.headers || {};

‎packages/google-cloud-texttospeech/src/v1beta1/text_to_speech_client.ts‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,9 @@ export class TextToSpeechClient {
484484
options = options || {};
485485
options.otherArgs = options.otherArgs || {};
486486
options.otherArgs.headers = options.otherArgs.headers || {};
487-
this.initialize();
487+
this.initialize().catch(err => {
488+
throw err;
489+
});
488490
this._log.info('listVoices request %j', request);
489491
const wrappedCallback:
490492
| Callback<
@@ -614,7 +616,9 @@ export class TextToSpeechClient {
614616
options = options || {};
615617
options.otherArgs = options.otherArgs || {};
616618
options.otherArgs.headers = options.otherArgs.headers || {};
617-
this.initialize();
619+
this.initialize().catch(err => {
620+
throw err;
621+
});
618622
this._log.info('synthesizeSpeech request %j', request);
619623
const wrappedCallback:
620624
| Callback<
@@ -663,7 +667,9 @@ export class TextToSpeechClient {
663667
* region_tag:texttospeech_v1beta1_generated_TextToSpeech_StreamingSynthesize_async
664668
*/
665669
streamingSynthesize(options?: CallOptions): gax.CancellableStream {
666-
this.initialize();
670+
this.initialize().catch(err => {
671+
throw err;
672+
});
667673
this._log.info('streamingSynthesize stream %j', options);
668674
return this.innerApiCalls.streamingSynthesize(null, options);
669675
}

‎packages/google-cloud-texttospeech/src/v1beta1/text_to_speech_long_audio_synthesize_client.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,9 @@ export class TextToSpeechLongAudioSynthesizeClient {
513513
this._gaxModule.routingHeader.fromParams({
514514
parent: request.parent ?? '',
515515
});
516-
this.initialize();
516+
this.initialize().catch(err => {
517+
throw err;
518+
});
517519
const wrappedCallback:
518520
| Callback<
519521
LROperation<
@@ -675,7 +677,7 @@ export class TextToSpeechLongAudioSynthesizeClient {
675677
listOperationsAsync(
676678
request: protos.google.longrunning.ListOperationsRequest,
677679
options?: gax.CallOptions
678-
): AsyncIterable<protos.google.longrunning.ListOperationsResponse> {
680+
): AsyncIterable<protos.google.longrunning.IOperation> {
679681
options = options || {};
680682
options.otherArgs = options.otherArgs || {};
681683
options.otherArgs.headers = options.otherArgs.headers || {};

‎packages/google-cloud-texttospeech/test/gapic_text_to_speech_long_audio_synthesize_v1.ts‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,9 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
257257
projectId: 'bogus',
258258
}
259259
);
260-
client.initialize();
260+
client.initialize().catch(err => {
261+
throw err;
262+
});
261263
assert(client.textToSpeechLongAudioSynthesizeStub);
262264
client.close().then(() => {
263265
done();
@@ -328,7 +330,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
328330
projectId: 'bogus',
329331
}
330332
);
331-
client.initialize();
333+
await client.initialize();
332334
const request = generateSampleMessage(
333335
new protos.google.cloud.texttospeech.v1.SynthesizeLongAudioRequest()
334336
);
@@ -364,7 +366,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
364366
projectId: 'bogus',
365367
}
366368
);
367-
client.initialize();
369+
await client.initialize();
368370
const request = generateSampleMessage(
369371
new protos.google.cloud.texttospeech.v1.SynthesizeLongAudioRequest()
370372
);
@@ -421,7 +423,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
421423
projectId: 'bogus',
422424
}
423425
);
424-
client.initialize();
426+
await client.initialize();
425427
const request = generateSampleMessage(
426428
new protos.google.cloud.texttospeech.v1.SynthesizeLongAudioRequest()
427429
);
@@ -455,7 +457,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
455457
projectId: 'bogus',
456458
}
457459
);
458-
client.initialize();
460+
await client.initialize();
459461
const request = generateSampleMessage(
460462
new protos.google.cloud.texttospeech.v1.SynthesizeLongAudioRequest()
461463
);
@@ -491,7 +493,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
491493
projectId: 'bogus',
492494
}
493495
);
494-
client.initialize();
496+
await client.initialize();
495497
const expectedResponse = generateSampleMessage(
496498
new operationsProtos.google.longrunning.Operation()
497499
);
@@ -516,7 +518,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
516518
projectId: 'bogus',
517519
}
518520
);
519-
client.initialize();
521+
await client.initialize();
520522
const expectedError = new Error('expected');
521523

522524
client.operationsClient.getOperation = stubSimpleCall(
@@ -539,7 +541,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
539541
projectId: 'bogus',
540542
}
541543
);
542-
client.initialize();
544+
await client.initialize();
543545
const request = generateSampleMessage(
544546
new operationsProtos.google.longrunning.GetOperationRequest()
545547
);
@@ -627,7 +629,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
627629
projectId: 'bogus',
628630
}
629631
);
630-
client.initialize();
632+
await client.initialize();
631633
const request = generateSampleMessage(
632634
new operationsProtos.google.longrunning.CancelOperationRequest()
633635
);
@@ -716,7 +718,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
716718
projectId: 'bogus',
717719
}
718720
);
719-
client.initialize();
721+
await client.initialize();
720722
const request = generateSampleMessage(
721723
new operationsProtos.google.longrunning.DeleteOperationRequest()
722724
);
@@ -821,8 +823,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
821823
];
822824
client.operationsClient.descriptor.listOperations.asyncIterate =
823825
stubAsyncIterationCall(expectedResponse);
824-
const responses: operationsProtos.google.longrunning.ListOperationsResponse[] =
825-
[];
826+
const responses: operationsProtos.google.longrunning.IOperation[] = [];
826827
const iterable = client.operationsClient.listOperationsAsync(request);
827828
for await (const resource of iterable) {
828829
responses.push(resource!);
@@ -844,7 +845,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
844845
projectId: 'bogus',
845846
}
846847
);
847-
client.initialize();
848+
await client.initialize();
848849
const request = generateSampleMessage(
849850
new operationsProtos.google.longrunning.ListOperationsRequest()
850851
);
@@ -853,8 +854,7 @@ describe('v1.TextToSpeechLongAudioSynthesizeClient', () => {
853854
stubAsyncIterationCall(undefined, expectedError);
854855
const iterable = client.operationsClient.listOperationsAsync(request);
855856
await assert.rejects(async () => {
856-
const responses: operationsProtos.google.longrunning.ListOperationsResponse[] =
857-
[];
857+
const responses: operationsProtos.google.longrunning.IOperation[] = [];
858858
for await (const resource of iterable) {
859859
responses.push(resource!);
860860
}

0 commit comments

Comments
 (0)