fix: remove is dependency (#6516)

sofisl · web-flow · commit 0cb9bb2180f3 · 2025-07-22T14:12:41.000-04:00
diff --git a/packages/google-cloud-vision/package.json b/packages/google-cloud-vision/package.json
@@ -50,8 +50,7 @@
   },
   "dependencies": {
     "@google-cloud/promisify": "^5.0.0",
-    "google-gax": "^5.0.0",
-    "is": "^3.3.0"
+    "google-gax": "^5.0.0"
   },
   "devDependencies": {
     "@google-cloud/storage": "^7.15.2",
diff --git a/packages/google-cloud-vision/src/helpers.ts b/packages/google-cloud-vision/src/helpers.ts
@@ -17,7 +17,6 @@
 // ** All changes to this file may be overwritten. **
 
 import * as fs from 'fs';
-import * as is from 'is';
 import {promisify} from '@google-cloud/promisify';
 import * as gax from 'google-gax';
 import * as protoTypes from '../protos/protos';
@@ -91,7 +90,7 @@ interface VisionClient {
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const _requestToObject = (request: any) => {
-  if (is.string(request)) {
+  if ((typeof request === 'string')) {
     // Is this a URL or a local file?
     // Guess based on what the string looks like, and build the full
     // request object in the correct format.
@@ -122,7 +121,7 @@ const _coerceRequest = (
 ) => {
   // At this point, request must be an object with an `image` key; if not,
   // it is an error. If there is no image, throw an exception.
-  if (!is.object(request) || is.undefined(request.image)) {
+  if ((typeof request !== 'object') || !(request.image)) {
     return callback(new Error('No image present.'));
   }
   // If this is a buffer, read it and send the object
@@ -183,7 +182,7 @@ const _createSingleFeatureMethod = (
     // If a callback was provided and options were skipped, normalize
     // the argument names.
     let callOptions: gax.CallOptions | undefined;
-    if (is.undefined(callback) && is.function(callOptionsOrCallback)) {
+    if (!callback && (typeof callOptionsOrCallback === 'function')) {
       callback = callOptionsOrCallback as gax.Callback<
         protoTypes.google.cloud.vision.v1.IAnnotateImageResponse,
         {},
@@ -296,7 +295,7 @@ export function call(apiVersion: string) {
     // If a callback was provided and options were skipped, normalize
     // the argument names.
     let callOptions: gax.CallOptions | undefined;
-    if (is.undefined(callback) && is.function(callOptionsOrCallback)) {
+    if (!callback && (typeof callOptionsOrCallback === 'function')) {
       callback = callOptionsOrCallback as gax.Callback<
         protoTypes.google.cloud.vision.v1.IAnnotateImageResponse,
         {},
diff --git a/packages/google-cloud-vision/test/helpers.test.ts b/packages/google-cloud-vision/test/helpers.test.ts
@@ -16,7 +16,6 @@
 
 import {describe, it, afterEach} from 'mocha';
 import * as path from 'path';
-import * as is from 'is';
 import * as sinon from 'sinon';
 import * as prototypes from '../protos/protos';
 import * as assert from 'assert';
@@ -236,7 +235,7 @@ describe('Vision helper methods', () => {
       };
       client.annotateImage(request, (err: {}, response: {}) => {
         // Establish that we got the expected response.
-        assert(is.undefined(err));
+        assert(!err);
         assert.deepStrictEqual(response, {
           logoAnnotations: [{description: 'Google'}],
         });
