Addressed codacy issues in DNS. #850

mderka · 2016-04-04T17:49:07Z

This includes

removing static formatter from example
removing and unifying imports and full qualification
removing unused serializable import from Dns
replacing assert not true with assertFalse in ITDnsTest
removing unused method from LocalDnsHelperTest.

I deliberately skipped some items which I discussed before with @ajkannan and we concluded that they should be ignored.

coveralls · 2016-04-04T17:55:17Z

Coverage remained the same at 85.537% when pulling 5be34a9 on mderka:codacy into d17e325 on GoogleCloudPlatform:master.

gcloud-java-examples/src/main/java/com/google/gcloud/examples/dns/DnsExample.java

    System.out.printf("Description: %s%n", zone.description());
-    System.out.printf("Created: %s%n", FORMATTER.format(new Date(zone.creationTimeMillis())));
+    DateFormat formatter = new SimpleDateFormat("YYYY-MM-dd HH:mm:ss");
+    System.out.printf("Created: %s%n", formatter.format(new Date(zone.creationTimeMillis())));


aozarov · 2016-04-04T19:33:21Z

Some more issues:

ZoneTest.java:352:64: error: ',' is not followed by whitespace.
LocalDnsHelper.CallRegex should have its member variables be final.
LocalDnsHelper delayChange member can be final.
LocalDnsHelper create method Javadoc is pointing to its contained class (Using {@code} is preferred in this case).
OptionParsers should have a private constructor.
ITDnsTest line 156 could use '==' instead of equals for enum value.
ProjectInfo.fromPb can directly return the created Quota.
pom.xml redundnt groupId (inherit from parent).

gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java

  static Function<Change, ChangeRequest> fromPbFunction(final Dns dns, final String zoneName) {
    return new Function<Change, ChangeRequest>() {
      @Override
-      public ChangeRequest apply(com.google.api.services.dns.model.Change pb) {


- removing static formatter from example - removing and unifying imports and full qualification - removing unused serializable import from Dns - replacing assert not true with assertFalse in ITDnsTest - removing unused method from LocalDnsHelperTest.

- added joda formatter to example - style in ZoneTest - visibility in LocalDnsHelper - added private constructor to OptionParsers - adjusted pom.xml

mderka · 2016-04-04T22:03:53Z

I addressed the pointed out issues. I rebased this PR due to conflict with some recently merged PR.

aozarov · 2016-04-04T22:16:09Z

Looks good. Feel free to merge after fixing the ProjectInfo.toPb and also cleaning up the other fully-qualified imports (and making sure build is green).

coveralls · 2016-04-04T23:25:23Z

Coverage decreased (-0.001%) to 85.543% when pulling ff65582 on mderka:codacy into 560d0b6 on GoogleCloudPlatform:master.

gcloud-java-examples/src/main/java/com/google/gcloud/examples/dns/DnsExample.java

          System.out.printf("%nID: %s%n", change.generatedId());
          System.out.printf("Status: %s%n", change.status());
-          System.out.printf("Started: %s%n", FORMATTER.format(change.startTimeMillis()));
+          System.out.printf("Started: %s%n", FORMATTER.print(change.startTimeMillis()));


- [ ] Regenerate this pull request now. chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/6a4d9d9bb3afb20b0f5fa4f5d9f6740b1d0eb19a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9

…ator_java versions (#850) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

🤖 I have created a release *beep* *boop* --- ## [2.3.3](googleapis/java-trace@v2.3.2...v2.3.3) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#850](googleapis/java-trace#850)) ([2f4c81e](googleapis/java-trace@2f4c81e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…#850)

…s#1687) (googleapis#850) * chore(java): add a note in README for migrated split repos (googleapis#1687) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <[email protected]> Source-Link: googleapis/synthtool@d4b2916 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jeff Ching <[email protected]> Co-authored-by: Deepankar Dixit <[email protected]>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Apr 4, 2016

mderka reviewed Apr 4, 2016
View reviewed changes

aozarov reviewed Apr 4, 2016
View reviewed changes

mderka added 2 commits April 4, 2016 15:00

Fixed some other minor issues:

c178259

- added joda formatter to example - style in ZoneTest - visibility in LocalDnsHelper - added private constructor to OptionParsers - adjusted pom.xml

mderka force-pushed the codacy branch from b236529 to c178259 Compare April 4, 2016 22:02

Unified imports of model objects.

ff65582

mziccard reviewed Apr 5, 2016
View reviewed changes

mderka merged commit 3e7069a into googleapis:master Apr 5, 2016

github-actions bot pushed a commit that referenced this pull request Oct 4, 2022

deps: update dependency com.google.cloud:google-cloud-core to v2.8.18 (…

6053905

…#850)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Addressed codacy issues in DNS. #850

Addressed codacy issues in DNS. #850

Uh oh!

mderka commented Apr 4, 2016

Uh oh!

coveralls commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mderka commented Apr 4, 2016

Uh oh!

aozarov commented Apr 4, 2016

Uh oh!

coveralls commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Addressed codacy issues in DNS. #850

Addressed codacy issues in DNS. #850

Uh oh!

Conversation

mderka commented Apr 4, 2016

Uh oh!

coveralls commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mderka commented Apr 4, 2016

Uh oh!

aozarov commented Apr 4, 2016

Uh oh!

coveralls commented Apr 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants