Make getProperties method public in BaseEntity#5452
Make getProperties method public in BaseEntity#5452sduskis merged 2 commits intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@igorbernstein2 Hi, I'm struggling to see the build failure here for formatting, mind pointing me in the right direction? |
|
Please run |
|
Thanks @igorbernstein2, formatted and updated |
|
Hi @sduskis, seems like all checks have passed, is there someone in specific I should request a review from? |
|
|
||
| ImmutableSortedMap<String, Value<?>> getProperties() { | ||
| /** Returns the properties. */ | ||
| public ImmutableSortedMap<String, Value<?>> getProperties() { |
There was a problem hiding this comment.
We don't want to expose Guava types as part of the public surface area. We may be able to investigate exposing this as a simple Map type.
Codecov Report
@@ Coverage Diff @@
## master #5452 +/- ##
============================================
+ Coverage 50.13% 50.82% +0.68%
- Complexity 22774 24173 +1399
============================================
Files 2271 2271
Lines 225018 229906 +4888
Branches 24839 25005 +166
============================================
+ Hits 112824 116841 +4017
- Misses 103704 104434 +730
- Partials 8490 8631 +141
Continue to review full report at Codecov.
|
* Make getProperties method public in BaseEntity * Using Map in getProperties
Addresses issue: #5451