Skip to content

Add integration tests for partitioning.#5439

Merged
shollyman merged 2 commits intogoogleapis:masterfrom
mmladenovski:part_it_tests
Jun 7, 2019
Merged

Add integration tests for partitioning.#5439
shollyman merged 2 commits intogoogleapis:masterfrom
mmladenovski:part_it_tests

Conversation

@mmladenovski
Copy link
Copy Markdown

@mmladenovski mmladenovski commented Jun 6, 2019

The tests in this change cover:

  • Reading from a column partitioned table.
  • Reading from a table that uses ingestion time partitioning.

@tswast or @shollyman, please review.

CC: @kmjung , @aryann

@mmladenovski mmladenovski requested a review from a team June 6, 2019 18:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #5439 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5439      +/-   ##
============================================
+ Coverage     50.31%   50.64%   +0.33%     
  Complexity    24045    24045              
============================================
  Files          2271     2271              
  Lines        229032   229085      +53     
  Branches      24225    25003     +778     
============================================
+ Hits         115226   116013     +787     
- Misses       104429   104444      +15     
+ Partials       9377     8628     -749
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/com/google/cloud/BaseService.java 55.55% <0%> (-6.95%) 2% <0%> (ø)
...le/cloud/compute/deprecated/DeprecationStatus.java 88.63% <0%> (-3.13%) 20% <0%> (ø)
...va/com/google/cloud/http/HttpTransportOptions.java 56.33% <0%> (-1.64%) 10% <0%> (ø)
...le/cloud/storage/contrib/nio/CloudStoragePath.java 75.67% <0%> (-0.69%) 51% <0%> (ø)
...ge/contrib/nio/CloudStorageFileSystemProvider.java 62.76% <0%> (-0.3%) 73% <0%> (ø)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.9% <0%> (-0.19%) 73% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 6.1% <0%> (-0.05%) 2% <0%> (ø)
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.82% <0%> (-0.01%) 1% <0%> (ø)
...restore/collection/ImmutableSortedMapIterator.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ud-core/src/main/java/com/google/cloud/Policy.java 96.61% <0%> (+0.02%) 12% <0%> (ø) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e6cab6...e35f690. Read the comment docs.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
shollyman
shollyman approved these changes Jun 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the codecov difference is likely due to a stale master. Could you pull the latest master and merge it into this branch? Once its done testing I'll go ahead and merge.

@mmladenovski
Add integration tests for partitioning.
6498b3f 
The tests in this change cover:

* Reading from a column partitioned table.
* Reading from a table that uses ingestion time partitioning.
@mmladenovski
Change column partition test to use DDL for setup.
e35f690 
Applying feedback from @shollyman.
@mmladenovski
Copy link
Copy Markdown
Author

mmladenovski commented Jun 7, 2019

@shollyman, rebased from latest master and updated the PR.

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@shollyman shollyman merged commit a364aab into googleapis:master Jun 7, 2019
@mmladenovski mmladenovski deleted the part_it_tests branch June 7, 2019 19:10
This was referenced Jun 12, 2019
Closed
Merged
@tswast tswast mentioned this pull request Aug 6, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mmladenovski @shollyman @chingor13 @sduskis @googlebot @yoshi-kokoro