Skip to content

Update google-auth-library to 0.16.1 and import using new bom#5413

Merged
chingor13 merged 5 commits intogoogleapis:masterfrom
chingor13:auth-library-bom
Jun 7, 2019
Merged

Update google-auth-library to 0.16.1 and import using new bom#5413
chingor13 merged 5 commits intogoogleapis:masterfrom
chingor13:auth-library-bom

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Jun 5, 2019 •
edited
Loading

  • Upgrades google-auth-library to 0.16.1
  • Upgrades google-http-client to 0.30.1
  • Upgrades google-oauth-client to 0.30.1
  • Import google-auth-library-bom
  • Drops dependency on Apache HttpClient which was only used to get a HTTP status code constant.

@chingor13 chingor13 requested a review from a team June 5, 2019 16:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
This was referenced Jun 5, 2019
Closed
Closed
sduskis
sduskis previously approved these changes Jun 5, 2019
View reviewed changes
@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Jun 5, 2019

Dependency convergence issues. Will need to update http-client in this PR too

@sduskis sduskis dismissed their stale review June 5, 2019 18:21

It looks like this actually fails. More changes need to be made.

@sduskis sduskis requested a review from a team June 5, 2019 18:21
sduskis
sduskis previously approved these changes Jun 5, 2019
View reviewed changes
@chingor13 chingor13 mentioned this pull request Jun 5, 2019
Closed
1 task
@sduskis sduskis self-requested a review June 5, 2019 21:23
@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Jun 5, 2019

Looks like we found a regression in http-client with the Data.nullOf for a Map type

@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 5, 2019
@chingor13 chingor13 changed the title Update google-auth-library to 0.16.0 and import using new bom Update google-auth-library to 0.16.1 and import using new bom Jun 7, 2019
This was referenced Jun 7, 2019
Closed
Closed
Closed
@chingor13 chingor13 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 7, 2019
@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Jun 7, 2019

@sduskis This is ready for review. We fixed the regression in google-http-client 1.30.1.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2019 •
edited
Loading

Codecov Report

Merging #5413 into master will increase coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5413      +/-   ##
============================================
+ Coverage     50.33%   50.64%   +0.31%     
- Complexity    22652    24060    +1408     
============================================
  Files          2271     2271              
  Lines        224309   229085    +4776     
  Branches      24890    24998     +108     
============================================
+ Hits         112896   116013    +3117     
- Misses       103676   104444     +768     
- Partials       7737     8628     +891
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.82% <0%> (ø) 1 <0> (ø) ⬇️
...va/com/google/cloud/compute/v1/InstanceClient.java 55.4% <0%> (-7.84%) 139% <0%> (+34%)
...oogle/cloud/kms/v1/KeyManagementServiceClient.java 62.78% <0%> (-7.22%) 91% <0%> (+22%)
...ava/com/google/cloud/compute/v1/ProjectClient.java 57.07% <0%> (-6.99%) 55% <0%> (+13%)
...va/com/google/cloud/compute/v1/SnapshotClient.java 55.73% <0%> (-6.88%) 31% <0%> (+7%)
...a/com/google/cloud/compute/v1/NodeGroupClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/SubnetworkClient.java 60.36% <0%> (-6.82%) 51% <0%> (+12%)
...d/compute/v1/RegionInstanceGroupManagerClient.java 54.5% <0%> (-6.79%) 51% <0%> (+12%)
.../com/google/cloud/compute/v1/TargetPoolClient.java 57.07% <0%> (-6.73%) 47% <0%> (+11%)
.../google/cloud/compute/v1/TargetSslProxyClient.java 54.28% <0%> (-6.69%) 35% <0%> (+8%)
... and 534 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556ac4b...a718a35. Read the comment docs.

@chingor13 chingor13 requested a review from JesseLovelace June 7, 2019 19:31
@chingor13 chingor13 merged commit 23347a7 into googleapis:master Jun 7, 2019
@chingor13 chingor13 deleted the auth-library-bom branch June 7, 2019 19:57
This was referenced Jun 12, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @sduskis @googlebot