Skip to content

Core-http:deprecated warnings removed#5407

Merged
chingor13 merged 1 commit intogoogleapis:masterfrom
abhinav-qlogic:core-http-warnings-4384
Jun 7, 2019
Merged

Core-http:deprecated warnings removed#5407
chingor13 merged 1 commit intogoogleapis:masterfrom
abhinav-qlogic:core-http-warnings-4384

Conversation

@abhinav-qlogic
Copy link
Copy Markdown

@abhinav-qlogic abhinav-qlogic commented Jun 5, 2019

work towards #4384

@abhinav-qlogic abhinav-qlogic requested a review from a team June 5, 2019 11:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
sduskis
sduskis previously requested changes Jun 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@sduskis sduskis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test failure:

[ERROR]   SessionPoolTest.testSessionNotFoundReadWriteTransaction:699 expected: com.google.cloud.spanner.TransactionRunnerImpl$TransactionContextImpl@12359a82
but was : Mock for TransactionContextImpl, hashCode: 1046545660

@abhinav-qlogic
Copy link
Copy Markdown
Author

abhinav-qlogic commented Jun 5, 2019

Please fix the test failure:

[ERROR]   SessionPoolTest.testSessionNotFoundReadWriteTransaction:699 expected: com.google.cloud.spanner.TransactionRunnerImpl$TransactionContextImpl@12359a82
but was : Mock for TransactionContextImpl, hashCode: 1046545660

failing test case is unrelated to changes

@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2019 •
edited
Loading

Codecov Report

Merging #5407 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5407      +/-   ##
============================================
+ Coverage     50.48%   50.75%   +0.27%     
- Complexity    23875    24801     +926     
============================================
  Files          2258     2271      +13     
  Lines        227486   233624    +6138     
  Branches      24978    25568     +590     
============================================
+ Hits         114838   118583    +3745     
- Misses       104029   106467    +2438     
+ Partials       8619     8574      -45
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/logging/spi/v2/GrpcLoggingRpc.java 37.01% <0%> (-6.11%) 1% <0%> (ø)
...loud/compute/v1/CreateSnapshotDiskHttpRequest.java 22.17% <0%> (-3.39%) 13% <0%> (+3%)
...rc/main/java/com/google/cloud/compute/v1/Disk.java 30.23% <0%> (-1.5%) 42% <0%> (+6%)
...com/google/cloud/redis/v1/stub/CloudRedisStub.java 6.66% <0%> (-1.03%) 2% <0%> (+1%)
...oogle/cloud/redis/v1beta1/stub/CloudRedisStub.java 6.66% <0%> (-1.03%) 2% <0%> (+1%)
...atransfer/v1/stub/GrpcDataTransferServiceStub.java 94.94% <0%> (-0.94%) 36% <0%> (+16%)
...google/cloud/redis/v1/stub/GrpcCloudRedisStub.java 91.69% <0%> (-0.52%) 27% <0%> (+13%)
...java/com/google/cloud/compute/v1/Interconnect.java 34.49% <0%> (-0.15%) 43% <0%> (+14%)
...oogle/cloud/compute/v1/InterconnectAttachment.java 36.05% <0%> (-0.08%) 57% <0%> (+26%)
...pute/v1/InterconnectDiagnosticsLinkLACPStatus.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24520a...8af4586. Read the comment docs.

@chingor13 chingor13 dismissed sduskis’s stale review June 7, 2019 17:58

Tests are passing

@chingor13 chingor13 merged commit 2e6cab6 into googleapis:master Jun 7, 2019
This was referenced Jun 12, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

+1 more reviewer

@sduskis sduskis sduskis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinav-qlogic @chingor13 @sduskis @googlebot @yoshi-kokoro