Fix FakeStorageRpc that doesn't set the blob size when returning blobs from the list method#5185
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
maxtomassi
force-pushed
the
fake-storage-set-blob-size
branch
from
7ede776 to
fa8e2bc
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
…s from the list method.
maxtomassi
force-pushed
the
fake-storage-set-blob-size
branch
from
fa8e2bc to
b9a5eca
Compare
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5185 +/- ##
============================================
+ Coverage 50.4% 50.4% +<.01%
- Complexity 23785 23786 +1
============================================
Files 2251 2251
Lines 226791 226797 +6
Branches 24966 24966
============================================
+ Hits 114320 114325 +5
- Misses 103864 103865 +1
Partials 8607 8607
Continue to review full report at Codecov.
|
|
@JesseLovelace can you please review this PR? |
… blobs from the list method. (#5185)
… blobs from the list method. (#5185)
8 participants
FakeStorageRpcimplements a list method that returns a list of the blobs that satisfy some given conditions. The current implementation doesn't set the size of the blobs that are returned. This would cause a problem if the client calling that method expects the size to be set in the blobs (pretty likely within a unit test). This PR fixes that issue by setting the size of the blobs being returned.