Skip to content

Regenerate spanner client#5063

Merged
chingor13 merged 1 commit intomasterfrom
autosynth-spanner
May 6, 2019
Merged

Regenerate spanner client#5063
chingor13 merged 1 commit intomasterfrom
autosynth-spanner

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented May 4, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-spanner/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:29bd82cc42c43825fde408e63fc955f3f9d07ff9989243d7aa0f91a35c7884dc
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 166 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 76 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 25 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 30 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team May 4, 2019 07:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2019
@chingor13 chingor13 requested a review from andreamlin May 6, 2019 18:17
@chingor13
Copy link
Copy Markdown
Contributor

chingor13 commented May 6, 2019

@andreamlin Does this need to sync with gax changes? It looks like we dropped a retry option.

@andreamlin
Copy link
Copy Markdown
Contributor

andreamlin commented May 6, 2019

@chingor13 Hey Jeff, I don't think this requires a gax-java change. The removal of DEADLINE_EXCEEDED is WAI.

andreamlin
andreamlin approved these changes May 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@andreamlin andreamlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit eae4a9d into master May 6, 2019
@kolea2 kolea2 mentioned this pull request May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andreamlin andreamlin andreamlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andreamlin andreamlin

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @chingor13 @andreamlin @googlebot