Monitoring: Regenerate VPCSC tests to include NotificationChannelService and UptimeCheckService.#5057
Merged
chingor13 merged 2 commits intogoogleapis:masterfrom May 6, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
The failed tests in Kokoro - Test: OSX Java 8 is a failed connection in the cloud-datastore tests. It is not related to my change in this PR. |
Codecov Report
@@ Coverage Diff @@
## master #5057 +/- ##
============================================
- Coverage 50.38% 50.38% -0.01%
Complexity 23735 23735
============================================
Files 2248 2248
Lines 226478 226478
Branches 24954 24954
============================================
- Hits 114116 114113 -3
- Misses 103769 103772 +3
Partials 8593 8593
Continue to review full report at Codecov.
|
steinwaywhw
changed the title
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chingor13
approved these changes
May 6, 2019
Contributor
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
We're working through issues with our OSX test executor. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a refresh of an auto-generated test to include NotificationChannelService. This has been tested locally. The pull request is sent on behalf of @michaelsafyan.