bigquery: deprecate ambiguous usage of delete in BigQuery client.#5052
Merged
shollyman merged 2 commits intogoogleapis:masterfrom May 2, 2019
Merged
bigquery: deprecate ambiguous usage of delete in BigQuery client.#5052shollyman merged 2 commits intogoogleapis:masterfrom
shollyman merged 2 commits intogoogleapis:masterfrom
Conversation
Now that datasets may contain resources other than just tables, deleting a resource using only the string identifiers without type information is ambiguous.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5052 +/- ##
============================================
- Coverage 50.38% 50.38% -0.01%
Complexity 23735 23735
============================================
Files 2248 2248
Lines 226478 226478
Branches 24954 24954
============================================
- Hits 114116 114113 -3
- Misses 103769 103772 +3
Partials 8593 8593
Continue to review full report at Codecov.
|
shollyman
changed the title
tswast
approved these changes
May 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that datasets may contain resources other than just tables,
deleting a resource using only the string identifiers without
type information is ambiguous.