Migrate from containsAllIn to containsAtLeastElementsIn.#5042
Merged
kolea2 merged 1 commit intogoogleapis:masterfrom May 2, 2019
cpovirk:containsallin
Merged
Migrate from containsAllIn to containsAtLeastElementsIn.#5042kolea2 merged 1 commit intogoogleapis:masterfrom cpovirk:containsallin
kolea2 merged 1 commit intogoogleapis:masterfrom
cpovirk:containsallin
Conversation
googlebot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
nithinsujir
approved these changes
May 1, 2019
kolea2
suggested changes
May 1, 2019
Contributor
kolea2
left a comment
kolea2
left a comment
There was a problem hiding this comment.
Looks like the builds are failing due to dependency issues. Can you please take a look?
The two behave identically, and containsAllIn is being removed. The new method was added in Truth 0.44, so update to that. That requires a migration from the removed ThrowableSubject.hasMessage(...) to hasMessageThat().isEqualTo(...). And to preserve RequireUpperBoundDeps, also update checker-compat-qual to 2.5.5.
Author
|
Thanks. I'm hoping that it's fixed now -- |
sduskis
added
the
kokoro:force-run
Contributor
|
@cpovirk, kokoro kicks in either with a google-cloud-java team member's PR or an explicit label on the PR. I'll kick off the build. |
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #5042 +/- ##
============================================
- Coverage 50.37% 49.74% -0.63%
+ Complexity 23722 22364 -1358
============================================
Files 2248 2248
Lines 226370 221747 -4623
Branches 24954 24073 -881
============================================
- Hits 114024 110301 -3723
+ Misses 103753 102996 -757
+ Partials 8593 8450 -143
Continue to review full report at Codecov.
|
Author
|
Ah, thanks! Looks like Kokoro is happy now. Code coverage is allegedly down slightly, but that seems unlikely to mean anything real here. |
kolea2
approved these changes
May 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two behave identically, and containsAllIn is being removed.
The new method was added in Truth 0.44, so update to that.