Logging: close() should flush logs#3909
Closed
SergeyZadorozhniy wants to merge 5 commits intogoogleapis:masterfrom
Closed
Logging: close() should flush logs#3909SergeyZadorozhniy wants to merge 5 commits intogoogleapis:masterfrom
SergeyZadorozhniy wants to merge 5 commits intogoogleapis:masterfrom
Conversation
googleapis#3866 Added flash inside close stage.
googlebot
added
the
cla: yes
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
changed the title
chingor13
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chingor13
reviewed
Nov 28, 2018
Contributor
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Thanks for submitting this and sorry for the delay in getting around to review it.
| closed = true; | ||
| rpc.close(); | ||
| try { | ||
| flush(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sduskis
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sduskis
added
the
do not merge
sduskis
added
status: blocked
Contributor
|
We need major changes before this can be merged. There's no reason to keep this open at this point. |
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.62.3-SNAPSHOT</summary> ### Updating meta-information for bleeding-edge SNAPSHOT release. </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3866
Added flash inside close stage.
Fixes #3866