Skip to content

BigQuery: Add support for retreiving labels#3879

Merged
JesseLovelace merged 2 commits intogoogleapis:masterfrom
JesseLovelace:master
Oct 30, 2018
Merged

BigQuery: Add support for retreiving labels#3879
JesseLovelace merged 2 commits intogoogleapis:masterfrom
JesseLovelace:master

Conversation

@JesseLovelace
Copy link
Copy Markdown
Contributor

Fixes #3817

@JesseLovelace JesseLovelace requested review from a team and chingor13 October 30, 2018 17:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass.

@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@JesseLovelace JesseLovelace merged commit f69e7fa into googleapis:master Oct 30, 2018
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
Attempt to generate a `GEMINI.md` file from the different README files
located throughout the repo.

This is intended to be a first draft and new information and entries can
be added and iterated upon.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
The Connection API should automatically remove any trailing semicolons in DDL statements. Spanner accepts trailing semicolons in queries and DML statements, but not in DDL statements. Previously, the Connection API would remove all comments and trailing semicolons from DDL statements. Comments are now supported in DDL statements, and are therefore no longer removed by the Conneciton API, but that change also unintentionally kept any trailing semicolons in the SQL string that is sent to Spanner.

Fixes https://togithub.com/cloudspannerecosystem/liquibase-spanner/issues/481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants