Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
googlebot
added
the
cla: no
Author
|
I signed it! |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
pongad
suggested changes
Mar 20, 2018
Contributor
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
Thank you very much for this.
Google Java style guide asks for 2-space indentation though. Could you please make this change. Other than that, this LGTM.
The code examples are outdated and need some rework. This is compatible with pubsub 0.40.0-beta
Fokko
force-pushed
the
fd-update-examples
branch
from
4c379cd to
6a18e69
Compare
Author
|
Thanks @pongad for reviewing. I've revised the commit with two spaces. Cheers |
pongad
approved these changes
Mar 21, 2018
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
* chore(main): release 3.16.2 * chore: generate libraries at Tue Aug 5 14:08:17 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <[email protected]>
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…3059) * Changed the names of the row and column variables to make their purpose clear. * Changed the code sample to reflect the real life usage * Updated the query and column names * Attempt to fix formatting. * Modified the IT test to match the query in the sample. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: PhongChuong <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
* chore(main): release 3.16.2 * chore: generate libraries at Tue Aug 5 14:08:17 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <[email protected]>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
… to v2.29.2 (#3059) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://togithub.com/google/error-prone)) | `2.28.0` -> `2.29.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.29.2`](https://togithub.com/google/error-prone/releases/tag/v2.29.2): Error Prone 2.29.2 This release contains all of the changes in [2.29.0](https://togithub.com/google/error-prone/releases/tag/v2.29.0) and [2.29.1](https://togithub.com/google/error-prone/releases/tag/v2.29.1), plus: - a bug fix for a crash in `TraditionalSwitchExpression` ([https://github.com/google/error-prone/issues/4479](https://togithub.com/google/error-prone/issues/4479)) - restores the `module-info` for the annotations jar, which was accidentally removed ([https://github.com/google/error-prone/issues/4480](https://togithub.com/google/error-prone/issues/4480)) Full Changelog: google/error-prone@v2.29.1...v2.29.2 ### [`v2.29.1`](https://togithub.com/google/error-prone/releases/tag/v2.29.1): Error Prone 2.29.1 This release contains all of the changes in [2.29.0](https://togithub.com/google/error-prone/releases/tag/v2.29.0), plus: - a bug fix to `UnusedVariable` to handle unnamed `_` variables ([https://github.com/google/error-prone/issues/4451](https://togithub.com/google/error-prone/issues/4451)) - a bug fix for a crash in `SetUnrecognized` ([https://github.com/google/error-prone/issues/4475](https://togithub.com/google/error-prone/issues/4475)) Full Changelog: google/error-prone@v2.29.0...v2.29.1 ### [`v2.29.0`](https://togithub.com/google/error-prone/releases/tag/v2.29.0): Error Prone 2.29.0 [Compare Source](https://togithub.com/google/error-prone/compare/v2.28.0...v2.29.0) New checks: - [`MissingRuntimeRetention`](https://errorprone.info/bugpattern/MissingRuntimeRetention) - [`SetUnrecognized`](https://errorprone.info/bugpattern/SetUnrecognized) - [`StatementSwitchToExpressionSwitch`](https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch) Closed issues: [#​4318](https://togithub.com/google/error-prone/issues/4318), [#​4429](https://togithub.com/google/error-prone/issues/4429), [#​4467](https://togithub.com/google/error-prone/issues/4467) Full Changelog: google/error-prone@v2.28.0...v2.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.43.0</summary> ## [2.43.0](googleapis/sdk-platform-java@v2.42.0...v2.43.0) (2024-07-25) ### Features * add `transport` option to `generation_config.yaml` ([#3052](googleapis/sdk-platform-java#3052)) ([2e6c95c](googleapis/sdk-platform-java@2e6c95c)) * get released version from versions.txt to render `README.md` ([#3007](googleapis/sdk-platform-java#3007)) ([204e73b](googleapis/sdk-platform-java@204e73b)) * Introduce java.time to Gax-Java ([#1872](googleapis/sdk-platform-java#1872)) ([300026a](googleapis/sdk-platform-java@300026a)) * Mark `getDefaultEndpoint()` with @ObsoleteApi ([#2347](googleapis/sdk-platform-java#2347)) ([311d4ed](googleapis/sdk-platform-java@311d4ed)) * parse `BUILD.bzel` to determine whether a commit that only changed `BUILD.bazel` is a qualified commit ([#2937](googleapis/sdk-platform-java#2937)) ([254bf37](googleapis/sdk-platform-java@254bf37)) ### Bug Fixes * Fix: ([8d11e25](googleapis/sdk-platform-java@8d11e25)) * `BaseApiTracer` to noop on attemptFailed via overloaded method call ([#3016](googleapis/sdk-platform-java#3016)) ([41532b4](googleapis/sdk-platform-java@41532b4)) * Generator to skip generation for empty services. ([#3051](googleapis/sdk-platform-java#3051)) ([1af3059](googleapis/sdk-platform-java@1af3059)) * restore hermetic build image publication ([#2952](googleapis/sdk-platform-java#2952)) ([2a5d36d](googleapis/sdk-platform-java@2a5d36d)) ### Dependencies * update dependency com.fasterxml.jackson:jackson-bom to v2.17.2 ([#3028](googleapis/sdk-platform-java#3028)) ([3c41fc4](googleapis/sdk-platform-java@3c41fc4)) * update dependency com.google.cloud.opentelemetry:detector-resources-support to v0.30.0 ([#2975](googleapis/sdk-platform-java#2975)) ([10fe657](googleapis/sdk-platform-java@10fe657)) * update dependency com.google.cloud.opentelemetry:detector-resources-support to v0.31.0 ([#3044](googleapis/sdk-platform-java#3044)) ([283c889](googleapis/sdk-platform-java@283c889)) * update dependency com.google.errorprone:error_prone_annotations to v2.29.2 ([#3058](googleapis/sdk-platform-java#3058)) ([f8bd80c](googleapis/sdk-platform-java@f8bd80c)) * update dependency com.google.errorprone:error_prone_annotations to v2.29.2 ([#3059](googleapis/sdk-platform-java#3059)) ([062add9](googleapis/sdk-platform-java@062add9)) * update dependency com.google.guava:guava to v33.2.1-jre ([#3027](googleapis/sdk-platform-java#3027)) ([e305208](googleapis/sdk-platform-java@e305208)) * update dependency commons-codec:commons-codec to v1.17.1 ([#3049](googleapis/sdk-platform-java#3049)) ([7934920](googleapis/sdk-platform-java@7934920)) * update dependency dev.cel:cel to v0.6.0 ([#3050](googleapis/sdk-platform-java#3050)) ([ae465dc](googleapis/sdk-platform-java@ae465dc)) * update dependency net.bytebuddy:byte-buddy to v1.14.18 ([#3029](googleapis/sdk-platform-java#3029)) ([e5382c4](googleapis/sdk-platform-java@e5382c4)) * update dependency org.apache.commons:commons-lang3 to v3.15.0 ([#3060](googleapis/sdk-platform-java#3060)) ([d62f6da](googleapis/sdk-platform-java@d62f6da)) * update dependency org.checkerframework:checker-qual to v3.45.0 ([#2988](googleapis/sdk-platform-java#2988)) ([2b524e5](googleapis/sdk-platform-java@2b524e5)) * update google api dependencies ([#2951](googleapis/sdk-platform-java#2951)) ([46ea538](googleapis/sdk-platform-java@46ea538)) * update google auth library dependencies to v1.24.0 ([#3039](googleapis/sdk-platform-java#3039)) ([55e9db2](googleapis/sdk-platform-java@55e9db2)) * update googleapis/java-cloud-bom digest to 47c5dbc ([#2974](googleapis/sdk-platform-java#2974)) ([f3f4036](googleapis/sdk-platform-java@f3f4036)) * update grpc dependencies to v1.65.1 ([#3061](googleapis/sdk-platform-java#3061)) ([e587e23](googleapis/sdk-platform-java@e587e23)) * update junit5 monorepo to v5.10.3 ([#2963](googleapis/sdk-platform-java#2963)) ([4a8eb0a](googleapis/sdk-platform-java@4a8eb0a)) * update netty dependencies to v4.1.112.final ([#3057](googleapis/sdk-platform-java#3057)) ([6b96a35](googleapis/sdk-platform-java@6b96a35)) * update opentelemetry-java monorepo to v1.40.0 ([#3035](googleapis/sdk-platform-java#3035)) ([564e4cb](googleapis/sdk-platform-java@564e4cb)) * Use Gapic-Showcase v0.35.1 ([#3018](googleapis/sdk-platform-java#3018)) ([82094b3](googleapis/sdk-platform-java@82094b3)) ### Documentation * add support option to 'new issue' choices ([#3055](googleapis/sdk-platform-java#3055)) ([674401b](googleapis/sdk-platform-java@674401b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
chingor13
pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
There are some changes in the recent API updates. I've updated the code examples to make it easier for others to conform to the changes. The current code examples are compatible with pubsub
0.40.0-beta.Cheers, Fokko