Skip to content

pubsub: remove polling implementation#3040

Merged
pongad merged 1 commit intogoogleapis:masterfrom
pongad:sub-rm-poll
Mar 14, 2018
Merged

pubsub: remove polling implementation#3040
pongad merged 1 commit intogoogleapis:masterfrom
pongad:sub-rm-poll

Conversation

@pongad
Copy link
Copy Markdown
Contributor

@pongad pongad commented Mar 14, 2018

There has been no way to use it since Aug 2017
and removing it will make moving the GAPIC stub easier.

There has been no way to use it since Aug 2017
and removing it will make moving the GAPIC stub easier.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2018
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit d70feec into googleapis:master Mar 14, 2018
@pongad pongad deleted the sub-rm-poll branch March 14, 2018 21:44
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
In this PR:
- Change `gapic_generator_version` as an optional parameter.
- Set `gapic_generator_version` through environment variable if it's not
specified in the generation config.

---------

Co-authored-by: Blake Li <[email protected]>
Co-authored-by: diegomarquezp <[email protected]>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
* chore: use a singleton session pool clock

* Changes the session pool maintainer clock to a singleton.
* Adds more tests for session pool maintenance.
* Makes sure the clock that is set in the options is used for all transactions.

* fix: freeze mock server to stop replenish before checking

* fix: get total sessions while holding lock

* test: skip session-not-found test for multiplexed

* test: fix flaky SpanTest

* fix: only throw exception if no session became available in the meantime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants